0001-public-do-not-redirect-if-template-rendering-is-empt.patch

Thomas Noël, 15 janvier 2019 11:59

Voir les différences: en ligne côte à côte

Subject: [PATCH] public: do not redirect if template rendering is empty
 (#29763)

Also, on template error, raise a 404 with a debug message.

 combo/public/views.py |  9 +++++++--
 tests/test_public.py  | 13 +++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

             raise PermissionDenied()
         if page.redirect_url:
             return HttpResponseRedirect(
                         page.get_redirect_url(context=request.extra_context_data))
             try:
                 redirect_url = page.get_redirect_url(context=request.extra_context_data)
             except utils.TemplateError:
                 raise Http404("combo: can't calculate the redirect URL (template error).")
             else:
                 if redirect_url:
                     return HttpResponseRedirect(redirect_url)
         cells = CellBase.get_cells(page=page)
         extend_with_parent_cells(cells, hierarchy=pages)

             resp = app.get('/elsewhere/', status=302)
             assert resp.location == 'http://example.net'
             page.redirect_url = '{{test_url}}/ok'
             page.save()
             resp = app.get('/elsewhere/', status=302)
             assert resp.location == 'http://example.net/ok'
             page.redirect_url = '{{unknown_variable}}'
             page.save()
             resp = app.get('/elsewhere/', status=200)
             page.redirect_url = '{% if error %}'
             page.save()
             resp = app.get('/elsewhere/', status=404)
     def test_page_private_unlogged(app):
         Page.objects.all().delete()
         page = Page(title='Home', slug='index', template_name='standard', public=False)
+    -

Produits Entr'ouvert » Combo