Projet

Général

Profil

0001-datasources-return-404-on-unknown-datasource-36808.patch

Nicolas Roche, 09 octobre 2019 18:58

Télécharger (1,92 ko)

Voir les différences:

Subject: [PATCH] datasources: return 404 on unknown datasource (#36808)

 tests/test_admin_pages.py | 5 +++++
 wcs/admin/data_sources.py | 7 +++++--
 2 files changed, 10 insertions(+), 2 deletions(-)
tests/test_admin_pages.py
4678 4678
    app.get('/backoffice/forms/data-sources/')
4679 4679
    app.get('/backoffice/workflows/data-sources/')
4680 4680

  
4681
    # unknown datasource
4682
    app.get('/backoffice/settings/data-sources/42/', status=404)
4683
    app.get('/backoffice/forms/data-sources/42/', status=404)
4684
    app.get('/backoffice/workflows/data-sources/42/', status=404)
4685

  
4681 4686
def test_data_sources_new(pub):
4682 4687
    create_superuser(pub)
4683 4688
    NamedDataSource.wipe()
wcs/admin/data_sources.py
19 19
from quixote.html import TemplateIO, htmltext
20 20

  
21 21
from ..qommon import _
22
from ..qommon import template
22
from ..qommon import errors, template
23 23
from ..qommon.form import *
24 24
from ..qommon.misc import json_response
25 25
from ..qommon.backoffice.menu import html_top
......
122 122
    do_not_call_in_templates = True
123 123

  
124 124
    def __init__(self, component):
125
        self.datasource = NamedDataSource.get(component)
125
        try:
126
            self.datasource = NamedDataSource.get(component)
127
        except KeyError:
128
            raise errors.TraversalError()
126 129
        self.datasource_ui = NamedDataSourceUI(self.datasource)
127 130
        get_response().breadcrumb.append((component + '/', self.datasource.name))
128 131

  
129
-