Projet

Général

Profil

0002-data-deprecate-get_last_update_time-using-signals-39.patch

Nicolas Roche, 23 janvier 2020 17:09

Télécharger (2,29 ko)

Voir les différences:

Subject: [PATCH 2/4] data: deprecate get_last_update_time using signals
 (#39091)

 combo/data/models.py |  6 +++++-
 tests/test_pages.py  | 13 +++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)
combo/data/models.py
351 351
            cell_types.add(cell.get_cell_type_str())
352 352
        if cell_types != set(self.related_cells.get('cell_types', [])):
353 353
            self.related_cells['cell_types'] = list(cell_types)
354
            self.save()
354
        self.save()
355 355

  
356 356
    def get_serialized_page(self):
357 357
        cells = [x for x in self.get_cells() if x.placeholder and not x.placeholder.startswith('_')]
......
431 431
        return utils.get_templated_url(self.redirect_url, context=context)
432 432

  
433 433
    def get_last_update_time(self):
434
        '''deprecated:
435
        page.last_update_timestamp is now updated by
436
        cell_maintain_page_cell_cache signal, triggered when saving cells.
437
        '''
434 438
        cells = CellBase.get_cells(page_id=self.id)
435 439
        return max([self.last_update_timestamp] + [x.last_update_timestamp for x in cells])
436 440

  
tests/test_pages.py
381 381
    response = app.get(page.get_online_url())
382 382
    assert "{{e-service_url}}backoffice/..." in response.text  # href not rendered
383 383

  
384
def test_cell_maintain_page_cell_cache(freezer):
385
    freezer.move_to('2020-01-01')
386
    page = Page(title='page-1', slug='page-1')
387
    page.save()
388
    cell = TextCell(page=page, order=0, slug='cell-1', text='foo')
389
    cell.save()
390
    assert page.last_update_timestamp.isoformat().startswith('2020-01-01')
391

  
392
    freezer.move_to('2020-02-02')
393
    cell.text = 'bar'
394
    cell.save()
395
    assert page.last_update_timestamp.isoformat().startswith('2020-02-02')
396

  
384 397
def test_page_is_new(freezer):
385 398
    freezer.move_to('2020-01-01')
386 399
    page = Page(title='page-1', slug='page-1')
387
-