0002-forms-force-authentication-if-anonymous-use-user-tra.patch

Nicolas Roche, 11 février 2020 14:24

Voir les différences: en ligne côte à côte

Subject: [PATCH 2/3] forms: force authentication if anonymous use user
 tracking code (#38239)

 tests/test_form_pages.py | 6 ++----
 wcs/forms/root.py        | 6 ++++++
 2 files changed, 8 insertions(+), 4 deletions(-)

         resp = resp.follow()
         assert resp.location == 'http://example.net/test/%s/' % formdata_id
         resp = resp.follow()
         assert 'form_comment' in resp.text # makes sure user is treated as submitter
         resp.forms[0]['comment'] = 'hello world'
         resp = resp.forms[0].submit()
         assert formdef.data_class().get(formdata_id).evolution[-1].comment == 'hello world'
         # and check we can also get back to it as anonymous
         # check we can't get back to it as anonymous
         app = get_app(pub)
         resp = app.get('/')
         resp.forms[0]['code'] = tracking_code
         resp = resp.forms[0].submit()
         assert resp.location == 'http://example.net/code/%s/load' % tracking_code
         resp = resp.follow()
         assert resp.location == 'http://example.net/test/%s/' % formdata_id
         resp = resp.follow()
         assert 'form_comment' in resp.text # makes sure user is treated as submitter
         assert resp.location == 'http://example.net/login/?ReturnUrl=http://example.net/test/%s' % formdata_id
         # and check a bot is not allowed to get it
         app = get_app(pub)
         resp = app.get('/code/%s/load' % tracking_code,
                 headers={'User-agent': 'Googlebot'}, status=403)
     def test_form_empty_tracking_code(pub, nocache):

                     raise KeyError
                 formdata = tracking_code.formdata
             except KeyError:
                 raise errors.TraversalError()
             if formdata.formdef.enable_tracking_codes is False:
                 raise errors.TraversalError()
             if BotFilter.is_bot():
                 raise errors.AccessForbiddenError()
             formdata_url = formdata.get_url().rstrip('/')
             if formdata.user_id and not get_request().user:
                 # anonymous user asked to load a tracking code associated with an user,
                 # don't load, ask for authentication instead
                 return redirect('/login/?ReturnUrl=%s' % formdata_url)
             get_session().mark_anonymous_formdata(formdata)
             return redirect(formdata.get_url())
     class TrackingCodesDirectory(Directory):
         _q_exports = ['load']
         def __init__(self, formdef=None):
+    -

Produits Entr'ouvert » w.c.s.