Projet

Général

Profil

0001-python3-remove-obsolete-sort-on-profile-fields-40502.patch

Nicolas Roche, 09 mars 2020 10:58

Télécharger (3,14 ko)

Voir les différences: 

Subject: [PATCH] python3: remove obsolete sort on profile fields (#40502)


 hobo/multitenant/settings_loaders.py |  1 -
 tests/test_settings_loaders.py       | 38 ++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletion(-)
 create mode 100644 tests/test_settings_loaders.py
hobo/multitenant/settings_loaders.py
325 325 

  		




  326
  326
  
    
    def update_settings_from_path(self, tenant_settings, path):

  		




  327
  327
  
    
        # profile fields

  		




  328
  328
  
    
        with open(path) as f:

  		




  329
  329
  
    
            hobo_json = json.load(f)

  		




  330
  330
  
    

  		




  331
  331
  
    
        fields = hobo_json.get('profile', {}).get('fields')

  		




  332
  332
  
    
        if fields:

  		




  333
  
  
    
            fields.sort(key=lambda x: x.get('order'))

  		




  334
  333
  
    
            fields = [x for x in fields if not x['disabled']]

  		




  335
  334
  
    
            tenant_settings.A2_PROFILE_FIELDS = [x['name'] for x in fields]

  		




  336
  335
  
    
            tenant_settings.A2_REQUIRED_FIELDS = [

  		




  337
  336
  
    
                    x['name'] for x in fields if x['required']]

  		




  338
  337
  
    
            tenant_settings.A2_REGISTRATION_FIELDS = [

  		




  339
  338
  
    
                    x['name'] for x in fields if x['asked_on_registration']]

  		




  340
  339
  
    

  		




  341
  340
  
    
        for service in hobo_json.get('services', []):

  		












  

    
      tests/test_settings_loaders.py
    
  





  
  1
  
    
import json

  		




  
  2
  
    
import os

  		




  
  3
  
    
import pytest

  		




  
  4
  
    

  		




  
  5
  
    
from django.conf import UserSettingsHolder

  		




  
  6
  
    

  		




  
  7
  
    
from hobo.deploy.utils import get_hobo_json

  		




  
  8
  
    
from hobo.environment.models import Authentic

  		




  
  9
  
    
from hobo.multitenant.settings_loaders import Authentic as AuthenticLoader

  		




  
  10
  
    

  		




  
  11
  
    
pytestmark = pytest.mark.django_db

  		




  
  12
  
    

  		




  
  13
  
    

  		




  
  14
  
    
def test_authentic_update_settings_from_path(tmpdir):

  		




  
  15
  
    
    a = Authentic(title='bar', slug='bar', base_url='http://bar.example.net')

  		




  
  16
  
    
    a.save()

  		




  
  17
  
    
    env = get_hobo_json()

  		




  
  18
  
    
    fields = env['profile']['fields']

  		




  
  19
  
    
    assert [x['name'] for x in fields if x['disabled']] == [u'country', u'birthdate']

  		




  
  20
  
    
    profile_fields = [x['name'] for x in fields if not x['disabled']]

  		




  
  21
  
    

  		




  
  22
  
    
    # integer field are not exported to hobo.json

  		




  
  23
  
    
    assert [x.get('order', 'undef') for x in env['profile']['fields']] == ['undef',] * 11

  		




  
  24
  
    

  		




  
  25
  
    
    # serialize hobo.json

  		




  
  26
  
    
    path = os.path.join(str(tmpdir), 'hobo.json')

  		




  
  27
  
    
    json.dump(env, open(path, 'w'))

  		




  
  28
  
    

  		




  
  29
  
    
    # call settings loaders

  		




  
  30
  
    
    tenant_settings = UserSettingsHolder({})

  		




  
  31
  
    
    assert not getattr(tenant_settings, 'A2_PROFILE_FIELDS', False)

  		




  
  32
  
    
    assert not getattr(tenant_settings, 'A2_REQUIRED_FIELDS', False)

  		




  
  33
  
    
    assert not getattr(tenant_settings, 'A2_REGISTRATION_FIELDS', False)

  		




  
  34
  
    
    loader = AuthenticLoader()

  		




  
  35
  
    
    loader.update_settings_from_path(tenant_settings, path)

  		




  
  36
  
    
    assert tenant_settings.A2_PROFILE_FIELDS == profile_fields

  		




  
  37
  
    
    assert tenant_settings.A2_REQUIRED_FIELDS == [u'first_name', u'last_name', u'email']

  		




  
  38
  
    
    assert tenant_settings.A2_REGISTRATION_FIELDS == [u'first_name', u'last_name']

  		




  0
  
  
    
-