Project

General

Profile

0001-lingo-always-return-200-OK-in-CallbackView-42729.patch

Valentin Deniaud, 11 May 2020 05:21 PM

Download (1.26 KB)

View differences: 

Subject: [PATCH] lingo: always return 200 OK in CallbackView (#42729)


 combo/apps/lingo/views.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
combo/apps/lingo/views.py
651 651 

  		




  652
  652
  
    
class CallbackView(PaymentView):

  		




  653
  653
  
    
    def handle_callback(self, request, backend_response, **kwargs):

  		




  
  654
  
    
        logger = logging.getLogger(__name__)

  		




  654
  655
  
    
        try:

  		




  655
  656
  
    
            self.handle_response(request, backend_response, **kwargs)

  		




  656
  
  
    
        except UnknownPaymentException as e:

  		




  657
  
  
    
            raise Http404(force_text(e))

  		




  658
  
  
    
        except PaymentException as e:

  		




  659
  
  
    
            return HttpResponseBadRequest(force_text(e))

  		




  
  657
  
    
        except Exception as e:

  		




  
  658
  
    
            raise logger.error('failed processing callback with backend response %s and error %s',

  		




  
  659
  
    
                               backend_response, e)

  		




  
  660
  
    
        # always return 200 OK to prevent information leakage

  		




  660
  661
  
    
        return HttpResponse()

  		




  661
  662
  
    

  		




  662
  663
  
    
    def get(self, request, *args, **kwargs):

  		




  663
  
  
    
-