0001-misc-set-Content-Disposition-header-for-exports-4706.patch

Benjamin Dauvergne, 28 septembre 2020 10:16

Voir les différences: en ligne côte à côte

Subject: [PATCH] misc: set Content-Disposition header for exports (#47060)

 bijoe/visualization/views.py | 7 +++++++
 tests/test_views.py          | 6 +++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

     from django.contrib import messages
     from django.utils.encoding import force_bytes, force_text
     from django.utils.text import slugify
     from django.utils.timezone import now
     from django.utils.translation import ungettext, ugettext as _
     from django.views.generic.edit import CreateView, DeleteView, UpdateView, FormView
     from django.views.generic.list import MultipleObjectMixin
-...
         def get(self, request, *args, **kwargs):
             response = HttpResponse(content_type='application/json')
             response['Content-Disposition'] = (
                 'attachment; filename="%s"' % 'export_stats_%s.json' % now().strftime('%Y%m%d')
+            )
             json.dump({'visualizations': [self.get_object().export_json()]}, response, indent=2)
             return response
-...
         def get(self, request, *args, **kwargs):
             response = HttpResponse(content_type='application/json')
             response['Content-Disposition'] = (
                 'attachment; filename="%s"' % 'export_stats_%s.json' % now().strftime('%Y%m%d')
+            )
             json.dump(export_site(), response, indent=2)
             return response

         app.get('/visualization/warehouse/schema1/fact1/', status=404)
     def test_import_visualization(schema1, app, admin, visualization, settings):
     def test_import_visualization(schema1, app, admin, visualization, settings, freezer):
         freezer.move_to('2020-01-01T00:00:00Z')
         settings.LANGUAGE_CODE = 'en-us'
         login(app, admin)
         resp = app.get('/visualization/%s/' % visualization.id)
         resp = resp.click('Export as JSON')
         assert resp.headers['content-type'] == 'application/json'
         assert resp.headers['content-disposition'] == 'attachment; filename="export_stats_20200101.json"'
         visualization_export = resp.text
         # invalid json
-...
         # global export/import
         resp = app.get('/').click('Export')
         assert resp.headers['content-type'] == 'application/json'
         assert resp.headers['content-disposition'] == 'attachment; filename="export_stats_20200101.json"'
         visualizations_export = resp.text
         Visualization.objects.all().delete()
+    -

Produits Entr'ouvert » BiJoe