0001-api-check-members-presence-before-removing-them-5086.patch

Benjamin Dauvergne, 04 février 2021 16:52

Voir les différences: en ligne côte à côte

Subject: [PATCH] api: check members presence before removing them (#50861)

It prevents the trigger of unneeded m2m_changed signals.

 src/authentic2/api_views.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

                             status=status.HTTP_201_CREATED)
         def delete(self, request, *args, **kwargs):
             self.role.members.remove(self.member)
             # prevent useless m2m_changed signals
             if self.role.members.filter(id=self.member.id):
                 self.role.members.remove(self.member)
             return Response({'result': 1, 'detail': _('User successfully removed from role')},
                             status=status.HTTP_200_OK)
-...
                     status=status.HTTP_201_CREATED)
         def delete(self, request, *args, **kwargs):
             self.role.members.remove(*self.members)
             # prevent useless m2m_changed signals
             members_to_delete = self.role.members.filter(id__in=[member.id for member in self.members])
             self.role.members.remove(*members_to_delete)
             return Response(
+                    {
                         'result': 1,
+    -

Produits Entr'ouvert » Authentic 2