0001-dataviz-do-not-accept-nested-lists-as-valid-data-516.patch

Valentin Deniaud, 10 mars 2021 15:03

Voir les différences: en ligne côte à côte

Subject: [PATCH] dataviz: do not accept nested lists as valid data (#51680)

 combo/apps/dataviz/models.py |  2 +-
 tests/test_dataviz.py        | 23 +++++++++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)

             x_labels = response['axis'].get('x_labels') or []
             y_labels = response['axis'].get('y_labels') or []
             if loop_labels:
                 if x_labels and y_labels:
                 if 'x_labels' in response['axis'] and 'y_labels' in response['axis']:
                     # no support for three dimensions
                     raise UnsupportedDataSet()
                 if not y_labels:

             'name': 'twelth visualization (all null)',
             'slug': 'twelth',
         },
+        {
             'data-url': 'https://bijoe.example.com/visualization/13/json/',
             'path': 'https://bijoe.example.com/visualization/13/iframe/?signature=123',
             'name': 'thirteenth visualization (loop with empty x_labels)',
             'slug': 'thirteenth',
         },
+    ]
-...
                 'measure': 'integer',
+            }
             return {'content': json.dumps(response), 'request': request, 'status_code': 200}
         if url.path == '/visualization/13/json/':
             response = {
                 'format': '1',
                 'data': [[[], []], [[], []], [[], []]],
                 'axis': {
                     'x_labels': [],
                     'y_labels': ['web', 'mail'],
                     'loop': ['a', 'b', 'c'],
                 },
+            }
             return {'content': json.dumps(response), 'request': request, 'status_code': 200}
     STATISTICS_LIST = {
-...
         with pytest.raises(HTTPError):
             chart = cell.get_chart()
         # loop and empty x_labels
         cell.statistic = Statistic.objects.get(slug='thirteenth')
         cell.save()
         with pytest.raises(UnsupportedDataSet):
             chart = cell.get_chart()
     @with_httmock(new_api_mock)
     def test_chartng_cell_new_api(app, new_api_statistics):
+    -

Produits Entr'ouvert » Combo