Projet

Général

Profil

0019-misc-fix-singleton-comparison-pylint-error-55505.patch

Lauréline Guérin, 12 juillet 2021 11:24

Télécharger (3,67 ko)

Voir les différences:

Subject: [PATCH 19/23] misc: fix singleton-comparison pylint error (#55505)

 tests/test_interval.py |  4 ++--
 tests/test_requests.py | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)
tests/test_interval.py
83 83
def test_interval_set_eq():
84 84
    assert IntervalSet([(1, 2)]) == [(1, 2)]
85 85
    assert [(1, 2)] == IntervalSet([(1, 2)])
86
    assert not IntervalSet([(1, 2)]) == None
87
    assert not None == IntervalSet([(1, 2)])
86
    assert not IntervalSet([(1, 2)]) == None  # noqa pylint: disable=singleton-comparison
87
    assert not None == IntervalSet([(1, 2)])  # noqa pylint: disable=singleton-comparison
tests/test_requests.py
39 39
        assert query['orig'][0] == 'myself'
40 40
        assert query['email'][0] == ''
41 41
        assert query['NameID'][0] == ''
42
        assert check_query(querystring, 'secret') == True
42
        assert check_query(querystring, 'secret') is True
43 43

  
44 44
        requests.get('/foo/bar/', remote_service=remote_service, without_user=True)
45 45
        url = send.call_args[0][0].url
......
49 49
        assert query['orig'][0] == 'myself'
50 50
        assert 'email' not in query
51 51
        assert 'NameID' not in query
52
        assert check_query(querystring, 'secret') == True
52
        assert check_query(querystring, 'secret') is True
53 53

  
54 54

  
55 55
def test_auto_sign():
......
60 60
        querystring = urlparse.urlparse(url)[4]
61 61
        query = urlparse.parse_qs(querystring, keep_blank_values=True)
62 62
        assert query['orig'][0] == 'chrono'
63
        assert check_query(querystring, 'chrono') == True
63
        assert check_query(querystring, 'chrono') is True
64 64

  
65 65
        requests.get('http://doesnotexist/foo/bar/', remote_service='auto')
66 66
        assert send.call_args[0][0].url == 'http://doesnotexist/foo/bar/'
......
80 80
        assert query['NameID'][0] == 'r2d2'
81 81
        assert 'email' not in query
82 82
        assert query['orig'][0] == 'myself'
83
        assert check_query(querystring, 'secret') == True
83
        assert check_query(querystring, 'secret') is True
84 84

  
85 85
        requests.get('/foo/bar/', remote_service=remote_service, user=user, federation_key='email')
86 86
        url = send.call_args[0][0].url
......
90 90
        assert query['email'][0] == 'foo@example.net'
91 91
        assert 'NameID' not in query
92 92
        assert query['orig'][0] == 'myself'
93
        assert check_query(querystring, 'secret') == True
93
        assert check_query(querystring, 'secret') is True
94 94

  
95 95
        user = MockUser(samlized=False)
96 96

  
......
102 102
        assert 'NameID' not in query
103 103
        assert query['email'][0] == 'foo@example.net'
104 104
        assert query['orig'][0] == 'myself'
105
        assert check_query(querystring, 'secret') == True
105
        assert check_query(querystring, 'secret') is True
106 106

  
107 107

  
108 108
def test_sign_anonymous_user():
......
119 119
        assert query['NameID'][0] == ''
120 120
        assert query['email'][0] == ''
121 121
        assert query['orig'][0] == 'myself'
122
        assert check_query(querystring, 'secret') == True
122
        assert check_query(querystring, 'secret') is True
123 123

  
124 124

  
125 125
def test_requests_cache():
126
-