0001-api_particulier-cache-svai-responses-44684.patch

Benjamin Dauvergne, 17 août 2021 15:49

Voir les différences: en ligne côte à côte

Subject: [PATCH] api_particulier: cache svai responses (#44684)

Only for 200 and 4xx status codes.

 passerelle/apps/api_particulier/models.py | 49 ++++++++++++++---------
 tests/conftest.py                         |  4 ++
 tests/test_api_particulier.py             | 41 +++++++++++++------
 3 files changed, 64 insertions(+), 30 deletions(-)

     from django.contrib.postgres.fields import ArrayField
     from django.core.cache import cache
     from django.db import models
     from django.utils import six
     from django.utils.six.moves.urllib import parse
-...
                 # avoid logging http errors about non-transport failure
                 message = data.get('message', '')
                 if message in KNOWN_ERRORS.get(response.status_code, []):
                     raise APIError(
                         message,
                         data={
                             'code': data.get('error', 'api-error').replace('_', '-'),
                             'status_code': response.status_code,
                             'platform': self.platform,
                             'content': data,
                         },
+                    )
                     error_data = {
                         'code': data.get('error', 'api-error').replace('_', '-'),
                         'status_code': response.status_code,
                         'platform': self.platform,
                         'content': data,
+                    }
                     if response.status_code // 100 == 4:
                         # for 40x errors, allow caching of the response, as it should not change with future requests
                         return {
                             'err': 1,
                             'err_desc': message,
                             'data': error_data,
+                        }
                     raise APIError(message, data=error_data)
                 raise APIError(
                     u'API-particulier platform "%s" returned a non 200 status %s: %s'
                     % (self.platform, response.status_code, data),
-...
             reference_avis = reference_avis.strip()[:13]
             if len(numero_fiscal) < 13 or len(reference_avis) < 13:
                 raise APIError('bad numero_fiscal or reference_avis, must be 13 chars long', status_code=400)
             return self.get(
                 'v2/avis-imposition',
                 params={
                     'numeroFiscal': numero_fiscal,
                     'referenceAvis': reference_avis,
                 },
                 user=user,
+            )
             cache_key = 'svai-%s-%s-%s' % (self.pk, numero_fiscal, reference_avis)
             data = cache.get(cache_key)
             if data is None:
                 data = self.get(
                     'v2/avis-imposition',
                     params={
                         'numeroFiscal': numero_fiscal,
                         'referenceAvis': reference_avis,
                     },
                     user=user,
+                )
                 # put in cache for two hours
                 cache.set(cache_key, data, 3600 * 2)
             else:
                 self.logger.info('found response in cache, "%s"', data)
             return data
         @endpoint(
             perm='can_access',

         finally:
             InMemoryCache._cache = {}
         from django.core.cache import cache
         cache.clear()
     @pytest.fixture
     def simple_user():

+        )
     def test_error(app, resource, mock_api_particulier):
         vector = [
+            (
                 ['impots_svair', 'avis-imposition'],
+                {
                     'numero_fiscal': '1234567890123',
                     'reference_avis': '3210987654321',
                 },
             ),
             (['caf_famille', 'situation-familiale'], {'code_postal': 12, 'numero_allocataire': '0000015'}),
+        ]
     vector = [
+        (
             ['impots_svair', 'avis-imposition'],
+            {
                 'numero_fiscal': '1234567890123',
                 'reference_avis': '3210987654321',
             },
         ),
         (['caf_famille', 'situation-familiale'], {'code_postal': 12, 'numero_allocataire': '0000015'}),
+    ]
     def test_error_500(app, resource, mock_api_particulier):
         with HTTMock(api_particulier_error_500):
             def do(endpoint, params):
-...
             for endpoints, params in vector:
                 for endpoint in endpoints:
                     do(endpoint, params)
     def test_not_json(app, resource, mock_api_particulier):
         with HTTMock(api_particulier_error_not_json):
             def do(endpoint, params):
-...
             for endpoints, params in vector:
                 for endpoint in endpoints:
                     do(endpoint, params)
     def test_not_found(app, resource, mock_api_particulier):
         with HTTMock(api_particulier_error_not_found):
             def do(endpoint, params):
-...
             for endpoints, params in vector:
                 for endpoint in endpoints:
                     do(endpoint, params)
     def test_connection_error(app, resource, mock_api_particulier):
         with HTTMock(api_particulier_connection_error):
             def do(endpoint, params):
-...
                 for endpoint in endpoints:
                     do(endpoint, params)
     def test_numero_fiscal_too_short(app, resource, mock_api_particulier):
         resp = endpoint_get(
             '/api-particulier/test/avis-imposition',
             app,
-...
         assert resp.json['err'] == 1
         assert resp.json['data'] is None
         assert 'must be 13 chars long' in resp.json['err_desc']
     def test_reference_avis_too_short(app, resource, mock_api_particulier):
         resp = endpoint_get(
             '/api-particulier/test/avis-imposition',
             app,
-...
                 },
+            )
         logs = ResourceLog.objects.all()
         assert logs.count() == 3
         if should_log:
             assert logs.count() == 3
             assert logs.filter(levelno=logging.ERROR).count() == 1
         else:
             assert logs.count() == 2
             assert not logs.filter(levelno=logging.ERROR).exists()
+    -

Projet

Général

Profil

Produits Entr'ouvert » Passerelle

0001-api_particulier-cache-svai-responses-44684.patch