0010-misc-fix-logging-not-lazy-pylint-error-56288.patch

Lauréline Guérin, 30 août 2021 17:53

Voir les différences: en ligne côte à côte

Subject: [PATCH 10/31] misc: fix logging-not-lazy pylint error (#56288)

 combo/apps/lingo/models.py | 31 +++++++++++++++++++------------
 combo/data/models.py       |  2 +-
 combo/utils/spooler.py     |  4 ++--
 3 files changed, 22 insertions(+), 15 deletions(-)

                 raise UnknownPaymentException('Received unknown payment response')
             else:
                 logger.debug(
                     'lingo: backend "%s" received payment response with id %%s' % self,
                     'lingo: backend "%s" received payment response with id %s',
                     self,
                     response.order_id,
                     extra=eopayment_response_to_extra_info(
                         response, lingo_transaction_id=transaction.pk, user=transaction.user
-...
             return basket_item
         def handle_backend_response(self, response, callback=True):
             logger.debug('lingo: regie "%s" handling response for transaction "%%s"' % self.regie, self.order_id)
             logger.debug('lingo: regie "%s" handling response for transaction "%s"', self.regie, self.order_id)
             if self.status == response.result:
                 # return early if self status didn't change (it means the
                 # payment service sent the response both as server to server and
-...
             if not self.is_running():
                 logger.info(
                     'lingo: regie "%s" received payment notification on existing '
                     'transaction, status changed, "%%s" (%%s) -> "%%s" (%%s)' % self.regie,
                     'transaction, status changed, "%s" (%s) -> "%s" (%s)',
                     self.regie,
                     status_label(self.status),
                     self.status,
                     status_label(response.result),
-...
                 # we accept unsigned cancellation requests as some platforms do
                 # that :/
                 logger.warning(
                     'lingo: regie "%s" received unsigned payment response with id %%s' % self.regie,
                     'lingo: regie "%s" received unsigned payment response with id %s',
                     self.regie,
                     response.order_id,
+                )
                 raise UnsignedPaymentException(self, 'Received unsigned payment response')
-...
                 # XXX: don't know if it can happen, but we would like to know when it does
                 # as for differed payments there can be multiple notifications.
                 logger.error(
                     'lingo: regie "%s" new transaction_date for transaction %%s(%%s) was %%s, received %%s'
                     % self.regie,
                     'lingo: regie "%s" new transaction_date for transaction %s(%s) was %s, received %s',
                     self.regie,
                     self.order_id,
                     self.id,
                     self.bank_transaction_date,
-...
             self.save()
             logger.info(
                 'lingo: regie "%s" received %s payment notification for transaction %%s(%%s)'
                 % (self.regie, 'synchronous' if callback else 'asynchronous'),
                 'lingo: regie "%s" received %s payment notification for transaction %s(%s)',
                 self.regie,
                 'synchronous' if callback else 'asynchronous',
                 self.order_id,
                 self.id,
                 extra=eopayment_response_to_extra_info(response),
-...
                 except Exception as e:
                     # ignore errors, it will be retried later on if it fails
                     logger.warning(
                         'lingo: regie "%s" error in sync notification for basket item %%s '
                         'and transaction %%s, %%s' % self.regie,
                         'lingo: regie "%s" error in sync notification for basket item %s '
                         'and transaction %s, %s',
                         self.regie,
                         item.id,
                         self.order_id,
                         e,
-...
                 except eopayment.PaymentException:
                     if ignore_errors:
                         logger.warning(
                             'lingo: regie "%s" polling backend for transaction "%%s(%%s)" failed' % self.regie,
                             'lingo: regie "%s" polling backend for transaction "%s(%s)" failed',
                             self.regie,
                             self.order_id,
                             self.id,
                             exc_info=True,
-...
                     raise PaymentException('polling failed')
                 logger.debug(
                     'lingo: regie "%s" polling backend for transaction "%%s(%%s)"' % self.regie,
                     'lingo: regie "%s" polling backend for transaction "%s(%s)"',
                     self.regie,
                     self.order_id,
                     self.id,
+                )

                     url = utils.get_templated_url(url, context=context)
                 except utils.TemplateError as e:
                     logger = logging.getLogger(__name__)
                     logger.warning('error in templated URL (%s): %s' % (url, e))
                     logger.warning('error in templated URL (%s): %s', url, e)
                 return '%s="%s"' % (attribute, url)
             text = re.sub(r'(href|src)="(.*?)"', sub_variadic_url, text)

                 try:
                     func(*args, **kwargs)
                 except Exception:
                     logger.exception('spooler: exception during %s(%s, %s)' % (func.__name__, args, kwargs))
                     logger.exception('spooler: exception during %s(%s, %s)', func.__name__, args, kwargs)
                 else:
                     logger.info('spooler: success of %s(%s, %s)' % (func.__name__, args, kwargs))
                     logger.info('spooler: success of %s(%s, %s)', func.__name__, args, kwargs)
         # pass arguments as pickles
         base_spooler = spool(pass_arguments=True)(spooler_func)
+    -

Projet

Général

Profil

Produits Entr'ouvert » Combo

0010-misc-fix-logging-not-lazy-pylint-error-56288.patch