Projet

Général

Profil

0025-misc-fix-consider-iterating-dictionary-pylint-error-.patch

Lauréline Guérin, 30 août 2021 17:54

Télécharger (4,32 ko)

Voir les différences:

Subject: [PATCH 25/31] misc: fix consider-iterating-dictionary pylint error
 (#56288)

 tests/test_search.py | 16 ++++++++--------
 tests/test_wcs.py    |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)
tests/test_search.py
834 834
    settings.KNOWN_SERVICES = {}
835 835
    search_engines = engines.get_engines()
836 836
    assert 'tracking-code' not in search_engines.keys()
837
    assert len([x for x in search_engines.keys() if x.startswith('formdata:')]) == 0
838
    assert len([x for x in search_engines.keys() if x.startswith('cards:')]) == 0
837
    assert len([x for x in search_engines if x.startswith('formdata:')]) == 0
838
    assert len([x for x in search_engines if x.startswith('cards:')]) == 0
839 839

  
840 840
    settings.KNOWN_SERVICES = {'wcs': {'default': {'title': 'test', 'url': 'http://127.0.0.1:8999/'}}}
841 841

  
842 842
    settings.TEMPLATE_VARS['is_portal_agent'] = False
843 843
    search_engines = engines.get_engines()
844
    assert len([x for x in search_engines.keys() if x.startswith('formdata:')]) == 0
844
    assert len([x for x in search_engines if x.startswith('formdata:')]) == 0
845 845

  
846 846
    settings.TEMPLATE_VARS['is_portal_agent'] = True
847 847
    search_engines = engines.get_engines()
848
    assert len([x for x in search_engines.keys() if x.startswith('formdata:')]) == 1
848
    assert len([x for x in search_engines if x.startswith('formdata:')]) == 1
849 849
    for key, engine in search_engines.items():
850 850
        if key.startswith('formdata:'):
851 851
            assert '&include-anonymised=off' in engine['url']
......
856 856
        # no card model found
857 857
        mock_wcs.return_value = {}
858 858
        search_engines = engines.get_engines()
859
        assert len([x for x in search_engines.keys() if x.startswith('cards:')]) == 0
859
        assert len([x for x in search_engines if x.startswith('cards:')]) == 0
860 860
        assert mock_wcs.call_args_list[0][0][1] == 'api/cards/@list'
861 861
        mock_wcs.return_value = {'data': []}
862 862
        search_engines = engines.get_engines()
863
        assert len([x for x in search_engines.keys() if x.startswith('cards:')]) == 0
863
        assert len([x for x in search_engines if x.startswith('cards:')]) == 0
864 864

  
865 865
        # card model found, but related page does not exist
866 866
        mock_wcs.return_value = {'data': [{'id': 'card-bar', 'text': 'Card Bar'}]}
867 867
        search_engines = engines.get_engines()
868
        assert len([x for x in search_engines.keys() if x.startswith('cards:')]) == 0
868
        assert len([x for x in search_engines if x.startswith('cards:')]) == 0
869 869

  
870 870
        # related page exists
871 871
        page = Page.objects.create(slug='bar', title='Bar')
......
873 873
            page.sub_slug = sub_slug
874 874
            page.save()
875 875
            search_engines = engines.get_engines()
876
            assert len([x for x in search_engines.keys() if x.startswith('cards:')]) == 1
876
            assert len([x for x in search_engines if x.startswith('cards:')]) == 1
877 877
            assert 'cards:c21f969b:card-bar' in search_engines.keys()
878 878
            card_engine = search_engines['cards:c21f969b:card-bar']
879 879
            assert card_engine['url'] == (
tests/test_wcs.py
2171 2171
    settings.TEMPLATE_VARS['is_portal_agent'] = True
2172 2172
    search_engines = engines.get_engines()
2173 2173
    assert 'tracking-code' in search_engines.keys()
2174
    assert len([x for x in search_engines.keys() if x.startswith('formdata:')]) == 2
2174
    assert len([x for x in search_engines if x.startswith('formdata:')]) == 2
2175 2175
    settings.TEMPLATE_VARS['is_portal_agent'] = False
2176 2176
    search_engines = engines.get_engines()
2177 2177
    assert 'tracking-code' not in search_engines.keys()
2178
    assert len([x for x in search_engines.keys() if x.startswith('formdata:')]) == 0
2178
    assert len([x for x in search_engines if x.startswith('formdata:')]) == 0
2179 2179

  
2180 2180

  
2181 2181
def test_backoffice_submission_cell_render(context):
2182
-