Projet

Général

Profil

0022-misc-fix-assignment-from-no-return-pylint-error-5698.patch

Valentin Deniaud, 21 septembre 2021 17:09

Télécharger (2,65 ko)

Voir les différences: 

Subject: [PATCH 22/59] misc: fix assignment-from-no-return pylint error
 (#56982)


 src/authentic2/custom_user/models.py | 3 +--
 src/authentic2/manager/user_views.py | 4 ++--
 src/authentic2/manager/views.py      | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)
src/authentic2/custom_user/models.py
336 336 

  		




  337
  337
  
    
    def save(self, *args, **kwargs):

  		




  338
  338
  
    
        update_fields = kwargs.get('update_fields')

  		




  339
  
  
    
        rc = super().save(*args, **kwargs)

  		




  
  339
  
    
        super().save(*args, **kwargs)

  		




  340
  340
  
    
        if not update_fields or not set(update_fields).isdisjoint({'first_name', 'last_name'}):

  		




  341
  341
  
    
            try:

  		




  342
  342
  
    
                self.attributes.first_name

  		




  ......




  352
  352
  
    
            else:

  		




  353
  353
  
    
                if self.attributes.last_name != self.last_name:

  		




  354
  354
  
    
                    self.attributes.last_name = self.last_name

  		




  355
  
  
    
        return rc

  		




  356
  355
  
    

  		




  357
  356
  
    
    def can_change_password(self):

  		




  358
  357
  
    
        return True

  		












  

    
      src/authentic2/manager/user_views.py
    
  





  666
  666
  
    
            qs = list(qs)

  		




  667
  667
  
    
        return qs

  		




  668
  668
  
    

  		




  669
  
  
    
    def authorize(self, request, *args, **kwargs):

  		




  670
  
  
    
        response = super().authorize(request, *args, **kwargs)

  		




  
  669
  
    
    def dispatch(self, request, *args, **kwargs):

  		




  
  670
  
    
        response = super().dispatch(request, *args, **kwargs)  # pylint: disable=assignment-from-no-return

  		




  671
  671
  
    
        if response is not None:

  		




  672
  672
  
    
            return response

  		




  673
  673
  
    
        if not UserDetailView.has_perm_on_roles(request.user, self.object):

  		












  

    
      src/authentic2/manager/views.py
    
  





  119
  119
  
    
                    raise PermissionDenied

  		




  120
  120
  
    

  		




  121
  121
  
    
    def dispatch(self, request, *args, **kwargs):

  		




  122
  
  
    
        response = self.authorize(request, *args, **kwargs)

  		




  
  122
  
    
        response = self.authorize(request, *args, **kwargs)  # pylint: disable=assignment-from-no-return

  		




  123
  123
  
    
        if response is not None:

  		




  124
  124
  
    
            return response

  		




  125
  125
  
    
        return super().dispatch(request, *args, **kwargs)

  		




  126
  
  
    
-