Projet

Général

Profil

0001-data-allow-blank-values-for-urls-in-site-settings-58.patch

Valentin Deniaud, 25 octobre 2021 14:55

Télécharger (2,57 ko)

Voir les différences: 

Subject: [PATCH] data: allow blank values for urls in site settings (#58152)


 combo/data/migrations/0049_sitesettings.py | 2 ++
 combo/data/models.py                       | 2 ++
 tests/test_manager.py                      | 8 ++++++++
 3 files changed, 12 insertions(+)
combo/data/migrations/0049_sitesettings.py
23 23 
                        max_length=100,
24 24 
                        verbose_name='Initial login page path',
25 25 
                        help_text='Page to redirect to the first time user logs in.',
26 
                        blank=True,
26 27 
                    ),
27 28 
                ),
28 29 
                (
......
31 32 
                        max_length=100,
32 33 
                        verbose_name='Welcome page path',
33 34 
                        help_text='Page to redirect to on the first visit, to suggest user to log in.',
35 
                        blank=True,
34 36 
                    ),
35 37 
                ),
36 38 
            ],
combo/data/models.py
2211 2211 
        _('Welcome page path'),
2212 2212 
        help_text=_('Page to redirect to on the first visit, to suggest user to log in.'),
2213 2213 
        max_length=100,
2214 
        blank=True,
2214 2215 
    )
2215 2216 
    initial_login_page_path = models.CharField(
2216 2217 
        _('Initial login page path'),
2217 2218 
        help_text=_('Page to redirect to the first time user logs in.'),
2218 2219 
        max_length=100,
2220 
        blank=True,
2219 2221 
    )
tests/test_manager.py
2650 2650 
    site_settings = SiteSettings.objects.get()
2651 2651 
    assert site_settings.welcome_page_path == '/welcome/'
2652 2652 
    assert site_settings.initial_login_page_path == '/initial-login/'
2653 

  		




  
  2654
  
    
    resp.form['welcome_page_path'] = ''

  		




  
  2655
  
    
    resp.form['initial_login_page_path'] = ''

  		




  
  2656
  
    
    resp.form.submit()

  		




  
  2657
  
    

  		




  
  2658
  
    
    site_settings.refresh_from_db()

  		




  
  2659
  
    
    assert site_settings.welcome_page_path == ''

  		




  
  2660
  
    
    assert site_settings.initial_login_page_path == ''

  		




  2653
  
  
    
-