0001-wcs-method-to-get-migrated-custom_schema-58800.patch

Lauréline Guérin, 06 janvier 2022 16:46

Voir les différences: en ligne côte à côte

Subject: [PATCH 1/3] wcs: method to get migrated custom_schema (#58800)

 combo/apps/wcs/forms.py  |  1 +
 combo/apps/wcs/models.py | 19 ++++++++++++++
 tests/test_wcs.py        | 57 ++++++++++++++++++++++++++++++++++++++--
 3 files changed, 75 insertions(+), 2 deletions(-)

combo/apps/wcs/forms.py
85	85	self.fields['carddef_reference'].widget = forms.Select(choices=card_models)
86	86	if self.instance.custom_schema:
87	87	self.initial['customize_display'] = True
	88	self.initial['custom_schema'] = self.instance.get_custom_schema()
88	89	if not self.instance.cached_json:
89	90	del self.fields['customize_display']
90	91	del self.fields['custom_schema']

             return WcsCardInfoCellForm
         def get_custom_schema(self):
             custom_schema = self.custom_schema or {}
             custom_schema['cells'] = custom_schema.get('cells') or []
             # migrate old formats
             for cell in custom_schema.get('cells') or []:
                 if cell.get('varname') == '@custom@':
                     if cell.get('display_mode') == 'value':
                         cell['display_mode'] = 'text'
                 elif not cell.get('field_content'):
                     if cell.get('display_mode') == 'title':
                         cell['field_content'] = 'value'
                     else:
                         cell['field_content'] = cell.get('display_mode') or 'value'
                     if cell.get('display_mode') in ['label', 'value', 'label-and-value']:
                         cell['display_mode'] = 'text'
             return custom_schema
     @register_cell_class
     class TrackingCodeInputCell(CellBase):

         assert 'customize_display' not in form.initial
         assert form.initial['custom_schema'] == {}
         cell.custom_schema = {'foo': 'bar'}
         cell.custom_schema = {'cells': [{'varname': 'foo', 'display_mode': 'value'}]}
         cell.save()
         form = form_class(instance=cell)
         assert 'customize_display' in form.fields
         assert 'custom_schema' in form.fields
         assert form.initial['customize_display'] is True
         assert form.initial['custom_schema'] == {'foo': 'bar'}
         assert form.initial['custom_schema'] == {
             'cells': [{'varname': 'foo', 'field_content': 'value', 'display_mode': 'text'}]
+        }
         app = login(app)
         resp = app.get('/manage/pages/%s/' % page.pk)
-...
         assert cell.custom_schema == {}
     def test_card_cell_custom_schema_migration():
         cell = WcsCardInfosCell()
         cell.custom_schema = {'grid_class': 'foobar', 'grid_layout_label': 'barfoo'}
         assert cell.get_custom_schema() == {
             'cells': [],
             'grid_class': 'foobar',
             'grid_layout_label': 'barfoo',
+        }
         cell.custom_schema = {
             'cells': [{'varname': 'some-field', 'display_mode': 'label', 'cell_size': 'foobar'}]
+        }
         assert cell.get_custom_schema() == {
             'cells': [
                 {'varname': 'some-field', 'field_content': 'label', 'display_mode': 'text', 'cell_size': 'foobar'}
+            ]
+        }
         cell.custom_schema = {'cells': [{'varname': 'some-field', 'display_mode': 'value'}]}
         assert cell.get_custom_schema() == {
             'cells': [{'varname': 'some-field', 'field_content': 'value', 'display_mode': 'text'}]
+        }
         cell.custom_schema = {'cells': [{'varname': 'some-field', 'display_mode': 'label-and-value'}]}
         assert cell.get_custom_schema() == {
             'cells': [{'varname': 'some-field', 'field_content': 'label-and-value', 'display_mode': 'text'}]
+        }
         cell.custom_schema = {'cells': [{'varname': 'some-field', 'display_mode': 'title'}]}
         assert cell.get_custom_schema() == {
             'cells': [{'varname': 'some-field', 'field_content': 'value', 'display_mode': 'title'}]
+        }
         cell.custom_schema = {
             'cells': [
                 {'varname': '@custom@', 'template': 'foobar', 'display_mode': 'label', 'cell_size': 'foobar'}
+            ]
+        }
         assert cell.get_custom_schema() == {
             'cells': [
                 {'varname': '@custom@', 'template': 'foobar', 'display_mode': 'label', 'cell_size': 'foobar'}
+            ]
+        }
         cell.custom_schema = {'cells': [{'varname': '@custom@', 'template': 'foobar', 'display_mode': 'value'}]}
         assert cell.get_custom_schema() == {
             'cells': [{'varname': '@custom@', 'template': 'foobar', 'display_mode': 'text'}]
+        }
         cell.custom_schema = {'cells': [{'varname': '@custom@', 'template': 'foobar', 'display_mode': 'title'}]}
         assert cell.get_custom_schema() == {
             'cells': [{'varname': '@custom@', 'template': 'foobar', 'display_mode': 'title'}]
+        }
     @mock.patch('combo.apps.wcs.utils.requests.send', side_effect=mocked_requests_send)
     def test_card_cell_save_cache(mock_send):
         page = Page.objects.create(title='xxx', slug='test_card_cell_save_cache', template_name='standard')
+    -

Projet

Général

Profil

Produits Entr'ouvert » Combo

0001-wcs-method-to-get-migrated-custom_schema-58800.patch