0002-api-use-StringOrListField-for-recurrence_days-serial.patch

Nicolas Roche, 14 février 2022 17:38

Voir les différences: en ligne côte à côte

Subject: [PATCH 2/2] api: use StringOrListField for recurrence_days serialiser
 (#60351)

 chrono/api/serializers.py |  2 +-
 tests/api/test_event.py   | 34 ++++++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 1 deletion(-)

     class AgendaSlugsSerializer(serializers.Serializer):
         agendas = CommaSeparatedStringField(
             required=True, child=serializers.SlugField(max_length=160, allow_blank=False)
+        )
     class EventSerializer(serializers.ModelSerializer):
         recurrence_days = CommaSeparatedStringField(
         recurrence_days = StringOrListField(
             required=False, child=serializers.IntegerField(min_value=0, max_value=6)
+        )
         class Meta:
             model = Event
             fields = [
                 'start_datetime',
                 'recurrence_days',

         agenda.kind = 'meetings'
         agenda.save()
         app.post('/api/agenda/%s/check/%s/' % (agenda.slug, event.slug), status=404)
         agenda.kind = 'virtual'
         agenda.save()
         app.post('/api/agenda/%s/check/%s/' % (agenda.slug, event.slug), status=404)
     @pytest.mark.parametrize(
         'days_in, days_out, err_msg',
+        [
             (1, None, 'Expected a list of items but got type "int".'),
             ('2', [2], None),
             ([3], [3], None),
             (['4'], [4], None),
             ([1, 2], [1, 2], None),
             (['2', '3'], [2, 3], None),
             ('4, 5', [4, 5], None),
         ],
+    )
     def test_string_or_list_serialiser(app, user, days_in, days_out, err_msg):
         app.authorization = ('Basic', ('john.doe', 'password'))
         agenda = Agenda(label='Foo bar')
         agenda.maximal_booking_delay = 0
         agenda.save()
         api_url = '/api/agenda/%s/event/' % (agenda.slug)
         params = {
             'start_datetime': '2022-02-03 16:00',
             'places': '1',
             'recurrence_days': days_in,
+        }
         if not err_msg:
             resp = app.post_json(api_url, params=params)
             assert not resp.json['err']
             assert Event.objects.get().recurrence_days == days_out
         else:
             resp = app.post_json(api_url, params=params, status=400)
             assert resp.json['err_desc'] == 'invalid payload'
             assert resp.json['errors']['recurrence_days'][0] == err_msg
     @pytest.mark.freeze_time('2021-11-01')
     def test_add_event(app, user):
         api_url = '/api/agenda/%s/event/' % ('999')
         # no authentication
         resp = app.post(api_url, status=401)
         assert resp.json['detail'] == 'Authentication credentials were not provided.'
+    -

Projet

Général

Profil

Produits Entr'ouvert » Chrono

0002-api-use-StringOrListField-for-recurrence_days-serial.patch