0002-dataviz-do-not-raise-error-in-check_validity-65615.patch

Valentin Deniaud, 24 mai 2022 15:04

Voir les différences: en ligne côte à côte

Subject: [PATCH 2/2] dataviz: do not raise error in check_validity (#65615)

 combo/apps/dataviz/models.py |  2 +-
 tests/test_dataviz.py        | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 2 deletions(-)

             resp = None
             try:
                 resp = self.get_statistic_data()
             except RequestException:
             except (RequestException, MissingRequest, MissingVariable):
                 pass
             self.set_validity_from_url(

     def test_dataviz_check_validity(nocache):
         page = Page.objects.create(title='One', slug='index')
         page = Page.objects.create(title='One', slug='index', extra_variables={'foo': 'bar'})
         stat = Statistic.objects.create(url='https://stat.com/stats/1/')
         cell = ChartNgCell.objects.create(page=page, order=1, placeholder='content', statistic=stat)
-...
             cell.check_validity()
         assert ValidityInfo.objects.exists() is False
         # cell using page variable is valid even if it cannot be evaluated
         cell.filter_params = {'test': 'variable:foo'}
         cell.save()
         with HTTMock(url_mock):
             cell.check_validity()
         assert ValidityInfo.objects.exists() is False
         cell.filter_params.clear()
         cell.save()
         @urlmatch(scheme='https', netloc=r'stat.com', path='/stats/1/')
         def url_mock2(url, request):
             return {'content': json.dumps({'data': [], 'err': 1}), 'status_code': 404}
+    -

Produits Entr'ouvert » Combo