0001-manager-add-view-to-edit-a-single-attribute-with-an-.patch

Frédéric Péters, 10 septembre 2022 20:53

Voir les différences: en ligne côte à côte

Subject: [PATCH] manager: add view to edit a single attribute with an ajax
 request (#64575)

 combo/manager/urls.py  |  5 +++++
 combo/manager/views.py | 43 ++++++++++++++++++++++++++++++++++++++++++
 tests/test_manager.py  | 34 +++++++++++++++++++++++++++++++++
 3 files changed, 82 insertions(+)

             views.page_duplicate_cell,
             name='combo-manager-page-duplicate-cell',
         ),
         re_path(
             r'^pages/(?P<page_pk>\d+)/cell/(?P<cell_reference>[\w_-]+)/attribute/(?P<attribute>[\w_]+)/$',
             views.page_edit_cell_attribute,
             name='combo-manager-page-edit-cell-attribute',
         ),
         re_path(
             r'^pages/(?P<page_pk>\d+)/cell/(?P<cell_reference>[\w_-]+)/add-link/(?P<link_code>[\w-]+)$',
             views.page_list_cell_add_link,

     page_duplicate_cell = PageDuplicateCellView.as_view()
     class PageEditCellAttributeView(ManagedPageMixin, UpdateView):
         http_method_names = ['post']
         def get_object(self, queryset=None):
             page_pk = self.kwargs.get('page_pk')
             cell_reference = self.kwargs.get('cell_reference')
             try:
                 return CellBase.get_cell(cell_reference, page_id=page_pk)
             except ObjectDoesNotExist:
                 raise Http404()
         def post(self, request, *args, **kwargs):
             self.object = self.get_object()
             attr = kwargs['attribute']
             form_class = forms.models.modelform_factory(
                 self.object.__class__,
                 fields=[attr],
+            )
             form = form_class(**self.get_form_kwargs())
             response = {}
             if form.is_valid():
                 response['err'] = 0
                 self.object = form.save()
                 PageSnapshot.take(
                     self.object.page,
                     request=self.request,
                     comment=_('changed cell "%(cell)s" (attribute: %(attr)s)')
                     % {
                         'cell': self.object,
                         'attr': attr,
                     },
+                )
             else:
                 response['err'] = 1
                 response['errorlist'] = form.errors
             return JsonResponse(response)
     page_edit_cell_attribute = PageEditCellAttributeView.as_view()
     class PageCellOrder(ManagedPageMixin, View):
         def get(self, *args, **kwargs):
             request = self.request

             assert TextCell.objects.get(id=cell.id).order == new_order[i]
     def test_edit_cell_attribute_ajax(settings, app, admin_user):
         Page.objects.all().delete()
         page = Page(title='One', slug='one', template_name='standard')
         page.save()
         cell = TextCell(page=page, placeholder='content', text='Foobar', order=0)
         cell.save()
         app = login(app)
         params = {
             'text': 'new text',
+        }
         app.post(
             f'/manage/pages/{page.id}/cell/data_textcell-{cell.id}/attribute/text/', params=params, status=403
+        )
         resp = app.get(f'/manage/pages/{page.id}/')
         params = {
             'text': 'new text',
             'csrfmiddlewaretoken': PyQuery(resp.text).find('[name=csrfmiddlewaretoken]').val(),
+        }
         resp = app.post(f'/manage/pages/{page.id}/cell/data_textcell-{cell.id}/attribute/text/', params=params)
         assert resp.json == {'err': 0}
         assert TextCell.objects.get(id=cell.id).text == 'new text'
         params = {
             'placeholder': '',
             'csrfmiddlewaretoken': params['csrfmiddlewaretoken'],
+        }
         resp = app.post(
             f'/manage/pages/{page.id}/cell/data_textcell-{cell.id}/attribute/placeholder/', params=params
+        )
         assert resp.json == {'err': 1, 'errorlist': {'placeholder': ['This field is required.']}}
     def test_edit_text_cell(app, admin_user):
         Page.objects.all().delete()
         page = Page(title='One', slug='one', template_name='standard')
+    -

Projet

Général

Profil

Produits Entr'ouvert » Combo

0001-manager-add-view-to-edit-a-single-attribute-with-an-.patch