Projet

Général

Profil

0001-manager-fix-custom-field-form-69467.patch

Lauréline Guérin, 22 septembre 2022 19:22

Télécharger (1,88 ko)

Voir les différences: 

Subject: [PATCH] manager: fix custom field form (#69467)


 chrono/manager/forms.py           | 2 +-
 tests/manager/test_events_type.py | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
chrono/manager/forms.py
399 399 
        if cleaned_data.get('varname') and not cleaned_data.get('label'):
400 400 
            self.add_error('label', _('This field is required.'))
401 401 
        if cleaned_data.get('varname') and not cleaned_data.get('field_type'):
402 
            self.add_error('field', _('This field is required.'))
402 
            self.add_error('field_type', _('This field is required.'))
403 403 

  		




  404
  404
  
    
        return cleaned_data

  		




  405
  405
  
    

  		












  

    
      tests/manager/test_events_type.py
    
  





  67
  67
  
    
    resp = app.get('/manage/events-type/%s/edit/' % events_type.pk)

  		




  68
  68
  
    
    resp.form['form-0-varname'] = 'foo'

  		




  69
  69
  
    
    resp.form['form-0-label'] = 'Foo'

  		




  
  70
  
    
    resp = resp.form.submit()

  		




  
  71
  
    
    assert resp.context['formset'][0].errors['field_type'] == ['This field is required.']

  		




  
  72
  
    
    resp.form['form-0-label'] = ''

  		




  70
  73
  
    
    resp.form['form-0-field_type'] = 'text'

  		




  71
  74
  
    
    resp = resp.form.submit()

  		




  
  75
  
    
    assert resp.context['formset'][0].errors['label'] == ['This field is required.']

  		




  
  76
  
    
    resp.form['form-0-label'] = 'Foo'

  		




  
  77
  
    
    resp = resp.form.submit()

  		




  72
  78
  
    
    assert resp.status_code == 302

  		




  73
  79
  
    
    events_type.refresh_from_db()

  		




  74
  80
  
    
    assert events_type.custom_fields == [

  		




  75
  
  
    
-