Projet

Général

Profil

0004-ldap-rename-process_controls-method-to-process_bind_.patch

Benjamin Renard, 10 novembre 2022 23:36

Télécharger (3,02 ko)

Voir les différences:

Subject: [PATCH 4/6] ldap: rename process_controls method to
 process_bind_controls

Licence: MIT
 src/authentic2/backends/ldap_backend.py | 6 +++---
 tests/test_ldap.py                      | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
src/authentic2/backends/ldap_backend.py
592 592
        return blocks
593 593

  
594 594
    @classmethod
595
    def process_controls(cls, request, block, conn, authz_id, ctrls):
595
    def process_bind_controls(cls, request, block, conn, authz_id, ctrls):
596 596
        attributes = cls.get_ppolicy_attributes(block, conn, authz_id)
597 597
        for c in ctrls:
598 598
            if c.controlType == ppolicy.PasswordPolicyControl.controlType:
......
730 730
                            else:
731 731
                                serverctrls = []
732 732
                            results = conn.simple_bind_s(authz_id, password, serverctrls=serverctrls)
733
                            self.process_controls(request, block, conn, authz_id, results[3])
733
                            self.process_bind_controls(request, block, conn, authz_id, results[3])
734 734
                            user_login_success(authz_id)
735 735
                            if not block['connect_with_user_credentials']:
736 736
                                try:
......
741 741
                            break
742 742
                        except ldap.INVALID_CREDENTIALS as e:
743 743
                            if block.get('use_controls') and len(e.args) > 0 and 'ctrls' in e.args[0]:
744
                                self.process_controls(
744
                                self.process_bind_controls(
745 745
                                    request, block, conn, authz_id, DecodeControlTuples(e.args[0]['ctrls'])
746 746
                                )
747 747
                            success, error = self.bind(block, conn)
tests/test_ldap.py
2191 2191
        '/login/', {'login-password-submit': '1', 'username': USERNAME, 'password': PASS}, follow=True
2192 2192
    )
2193 2193

  
2194
    def patched_process_controls(cls, request, block, conn, authz_id, ctrls):
2194
    def patched_process_bind_controls(cls, request, block, conn, authz_id, ctrls):
2195 2195
        raise exception[0]('oops')
2196 2196

  
2197 2197
    monkeypatch.setattr(
2198 2198
        ldap_backend.LDAPBackend,
2199
        'process_controls',
2200
        patched_process_controls,
2199
        'process_bind_controls',
2200
        patched_process_bind_controls,
2201 2201
    )
2202 2202
    client.post(
2203 2203
        '/login/', {'login-password-submit': '1', 'username': USERNAME, 'password': PASS}, follow=True
2204
-