0001-backoffice-allow-backoffice-submission-with-that-sin.patch

Frédéric Péters, 25 November 2022 07:50 AM

View differences: inline side by side

Subject: [PATCH] backoffice: allow backoffice submission with that single
 permission (#71694)

Method name got changed in 36110d80823da3312b334db5986278191bc601fb (#70194)
and the change was not made in those files.

 tests/backoffice_pages/test_submission.py | 26 +++++++++++++++++++++++
 wcs/backoffice/submission.py              |  4 ++--
 wcs/forms/preview.py                      |  2 +-
 3 files changed, 29 insertions(+), 3 deletions(-)

         resp = resp.follow().follow()
         assert 'parent:foobar' in resp.text  # parent var is ok
         assert 'computed:foobar' in resp.text  # and getting it via a computed var is also ok
     def test_backoffice_submission_no_roles(pub):
         user = create_user(pub)
         FormDef.wipe()
         formdef = FormDef()
         formdef.name = 'form title'
         formdef.fields = [
             fields.StringField(id='1', label='1st field', type='string'),
+        ]
         formdef.backoffice_submission_roles = user.roles[:]
         formdef.roles = ['XXX']  # role the agent doesn't have
         formdef.workflow_roles = {}
         formdef.store()
         formdef.data_class().wipe()
         app = login(get_app(pub))
         resp = app.get('/backoffice/submission/')
         resp = resp.click('form title')
         resp.forms[0]['f1'] = 'xxx'
         resp = resp.forms[0].submit('submit')  # -> validation
         resp = resp.forms[0].submit('submit').follow()  # -> submit
         assert formdef.data_class().count() == 1
         formdata = formdef.data_class().select()[0]
         assert formdata.data == {'1': 'xxx'}

             if not formdata.backoffice_submission:
                 raise errors.AccessForbiddenError()
             self.parent_directory.check_role()
             self.parent_directory.check_access()
             if self.parent_directory.edit_mode:
                 raise errors.AccessForbiddenError()
-...
         def check_authentication_context(self):
             pass
         def check_role(self):
         def check_access(self):
             if self.edit_mode:
                 return True
             if not self.formdef.backoffice_submission_roles:

         _q_exports = ['', 'tempfile', 'live']
         preview_mode = True
         def check_role(self):
         def check_access(self):
             pass
         def check_disabled(self):
+    -

Project

General

Profile

Produits Entr'ouvert » w.c.s.

0001-backoffice-allow-backoffice-submission-with-that-sin.patch