From 221c24d6e2234256c9d679b12e7133e42fb35ab0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= Date: Wed, 13 Jul 2016 16:33:47 +0200 Subject: [PATCH] misc: don't crash if tracking code is from a deleted formdata (#12571) --- wcs/forms/root.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/wcs/forms/root.py b/wcs/forms/root.py index 1e46f57..f5f24cb 100644 --- a/wcs/forms/root.py +++ b/wcs/forms/root.py @@ -179,12 +179,12 @@ class TrackingCodeDirectory(Directory): def load(self): try: tracking_code = get_publisher().tracking_code_class.get(self.code) + if tracking_code.formdata_id is None: + # this tracking code was not associated with any data; return a 404 + raise KeyError + formdata = tracking_code.formdata except KeyError: raise errors.TraversalError() - if tracking_code.formdata_id is None: - # this tracking code was not associated with any data; return a 404 - raise errors.TraversalError() - formdata = tracking_code.formdata if formdata.formdef.enable_tracking_codes is False: raise errors.TraversalError() get_session().mark_anonymous_formdata(formdata) -- 2.8.1