From 1e9ccf003916b8c808d0c0c143e6146a9af7a297 Mon Sep 17 00:00:00 2001 From: Josue Kouka Date: Mon, 20 Mar 2017 17:57:11 +0100 Subject: [PATCH] improved logged requests response content-type filtering (#15524) --- passerelle/settings.py | 2 +- tests/test_loggedrequests.py | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/passerelle/settings.py b/passerelle/settings.py index 5314711..bdc7209 100644 --- a/passerelle/settings.py +++ b/passerelle/settings.py @@ -168,7 +168,7 @@ REQUESTS_PROXIES = {} # List of LoggedRequest Response Content-Type to log LOGGED_CONTENT_TYPES_MESSAGES = ( - r'text/*', r'application/(json|xml)' + r'text/', r'application/(json|xml)' ) # Max size of the response to log diff --git a/tests/test_loggedrequests.py b/tests/test_loggedrequests.py index 4722938..e617475 100644 --- a/tests/test_loggedrequests.py +++ b/tests/test_loggedrequests.py @@ -63,7 +63,7 @@ def test_log_level(caplog, log_level): assert record.requests_response_content == response.content -@pytest.fixture(params=['xml', 'jpeg', 'pdf']) +@pytest.fixture(params=['xml', 'whatever', 'jpeg', 'pdf']) def endpoint_response(request): response_request = mock.Mock( headers={'Accept': '*/*', 'Authorization': 'Basic dG9rZW46dG9rZW4='}, body=None) @@ -71,6 +71,10 @@ def endpoint_response(request): headers={'Content-Type': 'application/xml; charset=charset=utf-8'}, status_code=200, content='xml test', request=response_request) + whatever = FakedResponse( + headers={'Content-Type': 'texto/csv'}, status_code=200, + content='username;age\ntoken;10\ncartman:10', request=response_request) + jpeg = FakedResponse( headers={'Content-Type': 'image/jpeg'}, status_code=200, content='binary content to be ignored', request=response_request) -- 2.11.0