From 52cf5ace6b8b1e1a77507639bf2e90346b1a64f4 Mon Sep 17 00:00:00 2001 From: Paul Marillonnet Date: Thu, 12 Oct 2017 11:01:59 +0200 Subject: [PATCH] LoginView: do not crash if an idp doesn't provide adequate metadata (#19260) --- mellon/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mellon/views.py b/mellon/views.py index e01dc13..fb2bac4 100644 --- a/mellon/views.py +++ b/mellon/views.py @@ -339,7 +339,7 @@ class LoginView(ProfileMixin, LogMixin, View): next_url = request.GET.get(REDIRECT_FIELD_NAME) idp = self.get_idp(request) - if idp is None: + if idp is None or idp == {}: return HttpResponseBadRequest('no idp found') self.profile = login = utils.create_login(request) self.log.debug('authenticating to %r', idp['ENTITY_ID']) -- 2.11.0