From 90ae4458702605228b150d332a9f3bbcac28f128 Mon Sep 17 00:00:00 2001 From: Paul Marillonnet Date: Fri, 22 Dec 2017 15:28:35 +0100 Subject: [PATCH] WIP do not crash on invalid global action name (#20874) --- wcs/admin/workflows.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/wcs/admin/workflows.py b/wcs/admin/workflows.py index 5edd490f..b37adeab 100644 --- a/wcs/admin/workflows.py +++ b/wcs/admin/workflows.py @@ -1293,10 +1293,14 @@ class GlobalActionsDirectory(Directory): return redirect('..') if form.is_submitted() and not form.has_errors(): - name = form.get_widget('name').parse() - action = self.workflow.add_global_action(name) - self.workflow.store() - return redirect('%s/' % action.id) + try: + name = form.get_widget('name').parse() + action = self.workflow.add_global_action(name) + self.workflow.store() + return redirect('%s/' % action.id) + except DuplicateGlobalActionNameError: + form.get_widget('name').set_error( + _('There is already an action with that name.')) get_response().breadcrumb.append(('new', _('New Global Action'))) html_top('workflows', title=_('New Global Action')) -- 2.11.0