From d94161af6c2f225fc372047111697f5d6b147b4e Mon Sep 17 00:00:00 2001 From: Thomas NOEL Date: Thu, 17 May 2018 15:16:55 +0200 Subject: [PATCH] really log invalid status detection (#23894) --- wcs/workflows.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/wcs/workflows.py b/wcs/workflows.py index 767f2dac..f8ccb0b7 100644 --- a/wcs/workflows.py +++ b/wcs/workflows.py @@ -1692,15 +1692,14 @@ class WorkflowStatusItem(XmlSerialisable): return [previous_status] return [] - try: - return [x for x in self.parent.parent.possible_status if x.id == self.status] - except IndexError: + targets = [x for x in self.parent.parent.possible_status if x.id == self.status] + if not targets: get_publisher().get_app_logger().error( 'reference to invalid status in workflow %s, status %s, item %s' % ( self.parent.parent.name, self.parent.name, self.description)) - return [] + return targets def get_jump_label(self): '''Return the label to use on a workflow graph arrow''' -- 2.17.0