From 6ea9890beafc101a21c61688f377bdf33410a981 Mon Sep 17 00:00:00 2001 From: Emmanuel Cazenave Date: Fri, 18 May 2018 19:07:20 +0200 Subject: [PATCH] rollback when DataImportError is raised (#23938) --- src/authentic2/manager/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/authentic2/manager/views.py b/src/authentic2/manager/views.py index 9a844302..67ac75e4 100644 --- a/src/authentic2/manager/views.py +++ b/src/authentic2/manager/views.py @@ -637,14 +637,14 @@ class SiteImportView(FormView): return self.form_invalid(form) try: - import_site(json_site, ImportContext()) + with transaction.atomic(): + import_site(json_site, ImportContext()) except DataImportError as e: form.add_error('site_json', unicode(e)) return self.form_invalid(form) return super(SiteImportView, self).form_valid(form) - @transaction.atomic def dispatch(self, request, *args, **kwargs): if not request.user.is_superuser: raise PermissionDenied -- 2.17.0