From 1b2c70dac7d44fe6d6000880d6f2b4b6090a900b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= Date: Mon, 28 May 2018 06:30:11 +0200 Subject: [PATCH 1/2] misc: do not add a message to prefilled fields (#24100) --- tests/test_form_pages.py | 4 ---- wcs/forms/root.py | 6 ------ 2 files changed, 10 deletions(-) diff --git a/tests/test_form_pages.py b/tests/test_form_pages.py index e9607bd2..e2062eba 100644 --- a/tests/test_form_pages.py +++ b/tests/test_form_pages.py @@ -1832,7 +1832,6 @@ def test_form_page_string_prefill(pub): resp = get_app(pub).get('/test/') assert resp.forms[0]['f0'].value == 'HELLO WORLD' assert 'widget-prefilled' in resp.body - assert not 'Value has been automatically prefilled.' in resp.body def test_form_page_profile_prefill(pub): user = create_user(pub) @@ -1859,7 +1858,6 @@ def test_form_page_formula_prefill(pub): resp = get_app(pub).get('/test/') assert resp.forms[0]['f0'].value == 'HELLO WORLD' assert 'widget-prefilled' in resp.body - assert 'Value has been automatically prefilled.' in resp.body def test_form_page_template_prefill(pub): user = create_user(pub) @@ -1874,7 +1872,6 @@ def test_form_page_template_prefill(pub): resp = app.get('/test/') assert resp.form['f0'].value == 'User Name' assert 'widget-prefilled' in resp.body - assert 'Value has been automatically prefilled.' in resp.body def test_form_page_query_string_prefill(pub): user = create_user(pub) @@ -1971,7 +1968,6 @@ def test_form_page_formula_prefill_items_field(pub): assert not resp.form['f0$element1'].checked assert resp.form['f0$element2'].checked assert 'widget-prefilled' in resp.body - assert 'Value has been automatically prefilled.' in resp.body resp.form['f0$element0'].checked = False resp = resp.form.submit('submit') diff --git a/wcs/forms/root.py b/wcs/forms/root.py index ecc4145a..ca1755dd 100644 --- a/wcs/forms/root.py +++ b/wcs/forms/root.py @@ -364,12 +364,6 @@ class FormPage(Directory, FormTemplateMixin): v = None if v: prefilled = True - if field.prefill and field.prefill.get('type') != 'string' and not verified: - # unless we prefilled with a fixed string, we - # inform the user the field value has been - # prefilled. - form.get_widget('f%s' % k).set_message( - _('Value has been automatically prefilled.')) form.get_widget('f%s' % k).prefilled = True if not prefilled and form.get_widget('f%s' % k): -- 2.17.0