From ab4753874552968079eb1fb4de817670bf8a8bec Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Thu, 14 Jun 2018 08:23:24 +0200 Subject: [PATCH] middlware: fix AttributeError in CollectIPMiddleware (fixes #24511) Ordering between process_request() and process_response() of middlewares is not guaranteed (if an early response is returned by a middleware in process_request() the response is still handled by all other middlewares). --- src/authentic2/middleware.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/authentic2/middleware.py b/src/authentic2/middleware.py index 3c24a19c..3393fb37 100644 --- a/src/authentic2/middleware.py +++ b/src/authentic2/middleware.py @@ -91,7 +91,7 @@ class LoggingCollectorMiddleware(object): class CollectIPMiddleware(object): def process_response(self, request, response): # only collect IP if session is used - if request.session.is_empty(): + if not hasattr(request, 'session') or request.session.is_empty(): return response ips = set(request.session.setdefault('ips', [])) -- 2.17.0