From 70a1bf5d23c815bdf983bcd64bcdc5e6b07e5009 Mon Sep 17 00:00:00 2001 From: Paul Marillonnet Date: Thu, 2 Aug 2018 14:35:31 +0200 Subject: [PATCH] do not crash on global action name duplicate (#20874) --- wcs/admin/workflows.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/wcs/admin/workflows.py b/wcs/admin/workflows.py index c408d215..b25e2617 100644 --- a/wcs/admin/workflows.py +++ b/wcs/admin/workflows.py @@ -1298,10 +1298,14 @@ class GlobalActionsDirectory(Directory): return redirect('..') if form.is_submitted() and not form.has_errors(): - name = form.get_widget('name').parse() - action = self.workflow.add_global_action(name) - self.workflow.store() - return redirect('%s/' % action.id) + try: + name = form.get_widget('name').parse() + action = self.workflow.add_global_action(name) + self.workflow.store() + return redirect('%s/' % action.id) + except DuplicateGlobalActionNameError: + form.get_widget('name').set_error( + _('There is already an action with that name.')) get_response().breadcrumb.append(('new', _('New Global Action'))) html_top('workflows', title=_('New Global Action')) -- 2.18.0