From 003ec25460022afae13d0cd378a07bdd6fb590d7 Mon Sep 17 00:00:00 2001 From: Thomas NOEL Date: Wed, 14 Nov 2018 10:04:22 +0100 Subject: [PATCH] fields: hide unused size attribute for string and text fields (#27977) --- wcs/fields.py | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/wcs/fields.py b/wcs/fields.py index 4d122d53..deabd69e 100644 --- a/wcs/fields.py +++ b/wcs/fields.py @@ -659,8 +659,13 @@ class StringField(WidgetField): def fill_admin_form(self, form): WidgetField.fill_admin_form(self, form) - form.add(StringWidget, 'size', title = _('Line length'), - value = self.size) + if self.size: + form.add(StringWidget, 'size', title=_('Line length'), + hint=_('Deprecated option, it is advised to use CSS classes ' + 'to size the fields in a manner compatible with all devices.'), + value=self.size) + else: + form.add(HiddenWidget, 'size', value=None) form.add(RegexStringWidget, 'validation', title = _('Validation regex'), value=self.validation, advanced=(not self.validation)) form.add(data_sources.DataSourceSelectionWidget, 'data_source', @@ -695,8 +700,13 @@ class TextField(WidgetField): def fill_admin_form(self, form): WidgetField.fill_admin_form(self, form) - form.add(StringWidget, 'cols', title = _('Line length'), - value = self.cols) + if self.cols: + form.add(StringWidget, 'cols', title=_('Line length'), + hint=_('Deprecated option, it is advised to use CSS classes ' + 'to size the fields in a manner compatible with all devices.'), + value=self.cols) + else: + form.add(HiddenWidget, 'cols', value=None) form.add(StringWidget, 'rows', title = _('Number of rows'), value = self.rows) form.add(StringWidget, 'maxlength', -- 2.19.1