From 18f8ede03fdc51ed496e89701918418c30016ddd Mon Sep 17 00:00:00 2001 From: Valentin Deniaud Date: Tue, 24 Mar 2020 17:26:33 +0100 Subject: [PATCH 2/6] api: use dict comprehension (#20535) --- passerelle/utils/api.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/passerelle/utils/api.py b/passerelle/utils/api.py index 4e658145..3a3c899a 100644 --- a/passerelle/utils/api.py +++ b/passerelle/utils/api.py @@ -61,7 +61,7 @@ class endpoint(object): 'patch': long_description_patch or long_description, } self.example_pattern = example_pattern - self.parameters = parameters + self.parameters = parameters or {} self.cache_duration = cache_duration self.post = post if post: @@ -80,8 +80,8 @@ class endpoint(object): return func def get_example_params(self): - return dict([(x, self.parameters[x]['example_value']) for x in self.parameters or {} - if x in self.parameters and 'example_value' in self.parameters[x]]) + return {param: info['example_value'] for param, info in self.parameters.items() + if 'example_value' in info} def get_query_parameters(self): query_parameters = [] @@ -115,7 +115,7 @@ class endpoint(object): } if self.example_pattern: kwargs['rest'] = self.example_pattern.format( - **dict([(x, '$%s$' % x) for x in self.get_example_params().keys()])) + **{x: '$%s$' % x for x in self.get_example_params().keys()}) url = reverse('generic-endpoint', kwargs=kwargs) for param in self.get_example_params(): -- 2.20.1