From 7861dc25a6dfdd627366dd85a60aa6cf6c6431de Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Thu, 2 Apr 2020 19:43:21 +0200 Subject: [PATCH] misc: update last_account_deletion_alert only if necessary (#41284) --- src/authentic2/utils/__init__.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/authentic2/utils/__init__.py b/src/authentic2/utils/__init__.py index c2ee4cc7..4c0841cd 100644 --- a/src/authentic2/utils/__init__.py +++ b/src/authentic2/utils/__init__.py @@ -437,8 +437,9 @@ def login(request, user, how, service_slug=None, nonce=None, **kwargs): if constants.LAST_LOGIN_SESSION_KEY not in request.session: request.session[constants.LAST_LOGIN_SESSION_KEY] = \ localize(to_current_timezone(last_login), True) - user.last_account_deletion_alert = None - user.save() + if user.last_account_deletion_alert is not None: + user.last_account_deletion_alert = None + user.save(update_fields=['last_account_deletion_alert']) record_authentication_event(request, how, nonce=nonce) hooks.call_hooks('event', name='login', user=user, how=how, service=service_slug) return continue_to_next_url(request, **kwargs) -- 2.24.0