From 0b903a8de24dfc09237447e87d93aef5751e35cb Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Fri, 12 Jun 2020 10:35:26 +0200 Subject: [PATCH] lingo: return empty list if retrieving invoice fails (#43967) --- combo/apps/lingo/models.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/combo/apps/lingo/models.py b/combo/apps/lingo/models.py index f5b06f13..c407ad1e 100644 --- a/combo/apps/lingo/models.py +++ b/combo/apps/lingo/models.py @@ -173,7 +173,13 @@ class Regie(models.Model): url = self.webservice_url + '/invoices/' if history: url += 'history/' - items = requests.get(url, user=user, remote_service='auto', cache_duration=0).json() + try: + response = requests.get(url, user=user, remote_service='auto', cache_duration=0) + response.raise_for_status() + except requests.RequestException: + # already logged by log errors if status != 2xx + return [] + items = response.json() if items.get('data'): return [build_remote_item(item, self) for item in items.get('data')] return [] -- 2.26.2