From da7588ee1dd33727b479857336a38cdddd9bfbb0 Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Thu, 18 Jun 2020 17:59:46 +0200 Subject: [PATCH] misc: log traceback for cron job exceptions (#44236) --- passerelle/base/management/commands/cron.py | 3 ++- tests/test_cron.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/passerelle/base/management/commands/cron.py b/passerelle/base/management/commands/cron.py index 0b8b8dcc..f5f6e5f8 100644 --- a/passerelle/base/management/commands/cron.py +++ b/passerelle/base/management/commands/cron.py @@ -48,7 +48,8 @@ class Command(BaseCommand): try: getattr(connector, frequency)() except Exception as e: - connector.logger.error('error running %s job (%r)' % (frequency, e)) + connector.logger.exception('connector "%s.%s" error running %s job' % ( + connector.get_connector_slug(), connector.slug, frequency)) errors.append({'connector': connector, 'exception': e, 'traceback': traceback.format_exc()}) if errors: for error in errors: diff --git a/tests/test_cron.py b/tests/test_cron.py index a3055783..df135e9c 100644 --- a/tests/test_cron.py +++ b/tests/test_cron.py @@ -20,4 +20,4 @@ def test_cron_error(db, caplog): new=mock.Mock(side_effect=excep)): with pytest.raises(CommandError): call_command('cron', 'hourly') - assert caplog.records[0].message == "error running hourly job (%s)" % repr(excep) + assert caplog.records[0].message == 'connector "base-adresse.base-adresse" error running hourly job' -- 2.26.2