From e6a0b2a5a52ec00f0dbd9dc7465413a75bcace3f Mon Sep 17 00:00:00 2001 From: Valentin Deniaud Date: Mon, 6 Jul 2020 15:30:58 +0200 Subject: [PATCH 2/2] tests: use reliable references to objects (#44861) --- tests/test_environment.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test_environment.py b/tests/test_environment.py index 9bf77b6..02ce816 100644 --- a/tests/test_environment.py +++ b/tests/test_environment.py @@ -205,8 +205,8 @@ def test_new_variable_service_view(app, admin_user): def test_variable_update_view(app, admin_user): app = login(app) - Variable.objects.create(name='foo', value='bar') - response = app.get('/sites/update-variable/1') + var = Variable.objects.create(name='foo', value='bar') + response = app.get('/sites/update-variable/%s' % var.pk) assert response.html.find('input', {'name': 'name'})['value'] == 'foo' assert response.html.find('textarea').text == '\nbar' response.form['value'] = 'barbar' @@ -217,8 +217,8 @@ def test_variable_update_view(app, admin_user): def test_variable_delete_view(app, admin_user): app = login(app) - Variable.objects.create(name='foo', value='bar') - response = app.get('/sites/delete-variable/1') + var = Variable.objects.create(name='foo', value='bar') + response = app.get('/sites/delete-variable/%s' % var.pk) assert response.html.find('h2').text == 'Removal of "foo"' response = response.form.submit() assert response.location == '/sites/variables' -- 2.20.1