From c2820e4a9e84cd89efc6b916699343d0b2719303 Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Sat, 24 Oct 2020 18:13:25 +0200 Subject: [PATCH 3/5] idp_oidc: add a simple oidc client fixture (#47900) --- tests/test_idp_oidc.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/test_idp_oidc.py b/tests/test_idp_oidc.py index 939494f1..093405d8 100644 --- a/tests/test_idp_oidc.py +++ b/tests/test_idp_oidc.py @@ -135,8 +135,7 @@ OIDC_CLIENT_PARAMS = [ ] -@pytest.fixture(params=OIDC_CLIENT_PARAMS) -def oidc_client(request, superuser, app, simple_user, oidc_settings): +def make_client(app, superuser, params=None): Attribute.objects.create( name='cityscape_image', label='cityscape', @@ -154,7 +153,7 @@ def oidc_client(request, superuser, app, simple_user, oidc_settings): response.form.set('ou', get_default_ou().pk) response.form.set('unauthorized_url', 'https://example.com/southpark/') response.form.set('redirect_uris', 'https://example.com/callbac%C3%A9') - for key, value in request.param.items(): + for key, value in (params or {}).items(): response.form.set(key, value) response = response.form.submit().follow() assert OIDCClient.objects.count() == 1 @@ -163,6 +162,16 @@ def oidc_client(request, superuser, app, simple_user, oidc_settings): return client +@pytest.fixture +def client(app, superuser): + return make_client(app, superuser, {}) + + +@pytest.fixture(params=OIDC_CLIENT_PARAMS) +def oidc_client(request, superuser, app, simple_user, oidc_settings): + return make_client(app, superuser, request.param) + + @pytest.fixture def normal_oidc_client(superuser, app, simple_user): url = reverse('admin:authentic2_idp_oidc_oidcclient_add') -- 2.29.2