From f2a340308ffd95014f26a54a325f842cb0098ed7 Mon Sep 17 00:00:00 2001 From: Valentin Deniaud Date: Wed, 21 Apr 2021 11:40:45 +0200 Subject: [PATCH] agendas: document reminder minimal delay (#53306) --- .../management/commands/send_booking_reminders.py | 3 +-- chrono/agendas/models.py | 10 +++++++++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/chrono/agendas/management/commands/send_booking_reminders.py b/chrono/agendas/management/commands/send_booking_reminders.py index 4b3495e..c68e681 100644 --- a/chrono/agendas/management/commands/send_booking_reminders.py +++ b/chrono/agendas/management/commands/send_booking_reminders.py @@ -51,11 +51,10 @@ class Command(BaseCommand): starts_before = timezone.now() + reminder_delta starts_after = timezone.now() + reminder_delta - timedelta(hours=6) - # prevent user who just booked from getting a reminder + # prevent user who just booked from getting a reminder (also documented in a help_text) created_before = timezone.now() - timedelta(hours=12) bookings = Booking.objects.filter( - event__agenda__reminder_settings__days__isnull=False, # useless ? cancellation_datetime__isnull=True, creation_datetime__lte=created_before, reminder_datetime__isnull=True, diff --git a/chrono/agendas/models.py b/chrono/agendas/models.py index 03b05f7..4613341 100644 --- a/chrono/agendas/models.py +++ b/chrono/agendas/models.py @@ -2390,7 +2390,15 @@ class AgendaReminderSettings(models.Model): ] agenda = models.OneToOneField(Agenda, on_delete=models.CASCADE, related_name='reminder_settings') - days = models.IntegerField(null=True, blank=True, choices=CHOICES, verbose_name=_('Send reminder')) + days = models.IntegerField( + null=True, + blank=True, + choices=CHOICES, + verbose_name=_('Send reminder'), + help_text=_( + 'In order to prevent users from getting a reminder shortly after booking, a reminder is sent less only if at least 12 hours have elapsed since booking time.' + ), + ) send_email = models.BooleanField(default=False, verbose_name=_('Notify by email')) email_extra_info = models.TextField( blank=True, -- 2.20.1