From 157105c29bc3b1e34132b7a0f1441eb9bb74e18c Mon Sep 17 00:00:00 2001
From: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Tue, 21 Sep 2021 11:00:34 +0200
Subject: [PATCH 39/59] misc: fix unnecessary-pass pylint error (#56982)

---
 src/authentic2/backends/ldap_backend.py    | 1 -
 src/authentic2/idp/saml/saml2_endpoints.py | 1 -
 src/authentic2/manager/views.py            | 4 ----
 src/authentic2/saml/fields.py              | 2 --
 4 files changed, 8 deletions(-)

diff --git a/src/authentic2/backends/ldap_backend.py b/src/authentic2/backends/ldap_backend.py
index 3672de2a..1b3a2599 100644
--- a/src/authentic2/backends/ldap_backend.py
+++ b/src/authentic2/backends/ldap_backend.py
@@ -831,7 +831,6 @@ class LDAPBackend:
                                     ' user'
                                 )
                             user_login_failure(authz_id)
-                            pass
                     else:
                         log.debug('user bind failed: invalid credentials')
                         if block['replicas']:
diff --git a/src/authentic2/idp/saml/saml2_endpoints.py b/src/authentic2/idp/saml/saml2_endpoints.py
index f80ec781..afdfab03 100644
--- a/src/authentic2/idp/saml/saml2_endpoints.py
+++ b/src/authentic2/idp/saml/saml2_endpoints.py
@@ -996,7 +996,6 @@ def reload_artifact(login):
         logger.debug('artifact found')
     except ObjectDoesNotExist:
         logger.debug('no artifact found')
-        pass
 
 
 @require_POST
diff --git a/src/authentic2/manager/views.py b/src/authentic2/manager/views.py
index f1912486..6d695a4b 100644
--- a/src/authentic2/manager/views.py
+++ b/src/authentic2/manager/views.py
@@ -433,8 +433,6 @@ class BaseTableView(
 ):
     '''Base class for views showing a table of objects'''
 
-    pass
-
 
 class SubTableViewMixin(
     TableHookMixin,
@@ -457,8 +455,6 @@ class SubTableViewMixin(
 class SimpleSubTableView(TitleMixin, SubTableViewMixin, TemplateView):
     '''Base class for views showing a simple table of objects related to one object'''
 
-    pass
-
 
 class BaseSubTableView(MultipleOUMixin, TitleMixin, SubTableViewMixin, FormNeedsRequest, FormView):
     '''Base class for views showing a table of objects related to one object'''
diff --git a/src/authentic2/saml/fields.py b/src/authentic2/saml/fields.py
index ec266114..f298843e 100644
--- a/src/authentic2/saml/fields.py
+++ b/src/authentic2/saml/fields.py
@@ -60,8 +60,6 @@ class PickledObject(str):
     a pickled object or not (if the object is an instance of this class
     then it must [well, should] be a pickled one)."""
 
-    pass
-
 
 class PickledObjectField(models.Field):
     def __from_db_value(self, value):
-- 
2.30.2