From 077749759ece6a2d26ace6cb50927f74f1b32a19 Mon Sep 17 00:00:00 2001 From: Valentin Deniaud Date: Mon, 20 Sep 2021 18:06:40 +0200 Subject: [PATCH 32/59] misc: fix consider-using-in pylint error (#56982) --- src/authentic2_idp_oidc/models.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/authentic2_idp_oidc/models.py b/src/authentic2_idp_oidc/models.py index 00ba3aa2..56088ad8 100644 --- a/src/authentic2_idp_oidc/models.py +++ b/src/authentic2_idp_oidc/models.py @@ -190,14 +190,10 @@ class OIDCClient(Service): else: if parsed_uri.path.rstrip('/') != parsed_valid_uri.path.rstrip('/'): continue - if parsed_uri.query and ( - parsed_valid_uri.query != parsed_uri.query and parsed_valid_uri.query != '*' - ): + if parsed_uri.query and parsed_valid_uri.query not in (parsed_uri.query, '*'): # xxx parameter validation continue - if parsed_uri.fragment and ( - parsed_valid_uri.fragment != parsed_uri.fragment and parsed_valid_uri.fragment != '*' - ): + if parsed_uri.fragment and parsed_valid_uri.fragment not in (parsed_uri.fragment, '*'): continue return raise ValueError('redirect_uri is not declared') -- 2.30.2