From bebf8b9d9e9e4dd22e4554970ff816ecf22c9b14 Mon Sep 17 00:00:00 2001 From: Valentin Deniaud Date: Mon, 20 Sep 2021 16:35:04 +0200 Subject: [PATCH 27/59] misc: fix consider-using-ternary pylint error (#56982) --- src/authentic2/apps/journal/models.py | 2 +- src/authentic2/utils/misc.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/authentic2/apps/journal/models.py b/src/authentic2/apps/journal/models.py index 5883eaba..e6349238 100644 --- a/src/authentic2/apps/journal/models.py +++ b/src/authentic2/apps/journal/models.py @@ -393,7 +393,7 @@ class Event(models.Model): @property def session_id_shortened(self): - return (self.session_id and self.session_id[:6]) or '-' + return self.session_id[:6] if self.session_id else '-' @property def message(self): diff --git a/src/authentic2/utils/misc.py b/src/authentic2/utils/misc.py index 0c270f4d..b8d26649 100644 --- a/src/authentic2/utils/misc.py +++ b/src/authentic2/utils/misc.py @@ -1054,6 +1054,7 @@ def get_next_url(params, field_name=None): def select_next_url(request, default, field_name=None, include_post=False, replace=None): '''Select the first valid next URL''' + # pylint: disable=consider-using-ternary next_url = (include_post and get_next_url(request.POST, field_name=field_name)) or get_next_url( request.GET, field_name=field_name ) -- 2.30.2