From 4fd2151477229e81aa1c3e804d9fa3a9c6b347cd Mon Sep 17 00:00:00 2001 From: Valentin Deniaud Date: Mon, 25 Oct 2021 12:24:21 +0200 Subject: [PATCH] manager: handle unknown page slug in redirect to edit view (#58117) --- combo/manager/views.py | 2 ++ tests/test_manager.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/combo/manager/views.py b/combo/manager/views.py index 1c1a4a88..edbf3324 100644 --- a/combo/manager/views.py +++ b/combo/manager/views.py @@ -589,6 +589,8 @@ class PageRedirectToEditView(RedirectView): page = get_page_from_url_parts(page_path.split('/')) except MissingSubSlug as e: page = e.page + if not page: + raise Http404() return reverse('combo-manager-page-view', kwargs={'pk': page.pk}) diff --git a/tests/test_manager.py b/tests/test_manager.py index 8c2d08ed..310bacd3 100644 --- a/tests/test_manager.py +++ b/tests/test_manager.py @@ -2635,6 +2635,8 @@ def test_redirect_to_page_edit(app, admin_user): resp = app.get('/manage/pages/users/xxx/', status=302) assert resp.location == '/manage/pages/%s/' % page3.pk + resp = app.get('/manage/pages/missing/', status=404) + def test_site_settings(app, admin_user): app = login(app) -- 2.30.2