From 191fabd99983362044de3c41ea0fc17f90e56d71 Mon Sep 17 00:00:00 2001 From: Valentin Deniaud Date: Wed, 27 Oct 2021 15:43:34 +0200 Subject: [PATCH 1/2] journal_event_types: fix incorrect FranceConnect identifier (#57932) --- src/authentic2/journal_event_types.py | 2 +- tests/test_manager_journal.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/authentic2/journal_event_types.py b/src/authentic2/journal_event_types.py index 1176c32f..b0c2a2ae 100644 --- a/src/authentic2/journal_event_types.py +++ b/src/authentic2/journal_event_types.py @@ -111,7 +111,7 @@ class EventTypeWithHow(EventTypeWithService): def login_method_label(how): if how.startswith('password'): return _('password') - elif how == 'fc': + elif how == 'france-connect': return 'FranceConnect' elif how == 'saml': return 'SAML' diff --git a/tests/test_manager_journal.py b/tests/test_manager_journal.py index 2a14ed37..e9f47837 100644 --- a/tests/test_manager_journal.py +++ b/tests/test_manager_journal.py @@ -71,7 +71,7 @@ def events(db, freezer): user=user, session=session1, service=service, - how="franceconnect", + how="france-connect", ) make("user.logout", user=user, session=session1) @@ -320,7 +320,7 @@ def test_global_journal(app, superuser, events): 'user': '-', }, { - 'message': 'registration using franceconnect', + 'message': 'registration using FranceConnect', 'timestamp': 'Jan. 1, 2020, 1 a.m.', 'type': 'user.registration', 'user': 'Johnny doe', @@ -608,7 +608,7 @@ def test_user_journal(app, superuser, events): assert content == [ { - 'message': 'registration using franceconnect', + 'message': 'registration using FranceConnect', 'timestamp': 'Jan. 1, 2020, 1 a.m.', 'type': 'user.registration', 'user': 'Johnny doe', -- 2.30.2