From 22e6c3e999c0dbd08e6c24437a360a5acafef15e Mon Sep 17 00:00:00 2001
From: Valentin Deniaud <vdeniaud@entrouvert.com>
Date: Wed, 23 Mar 2022 14:26:07 +0100
Subject: [PATCH 1/2] manager: make time period exception source views more
 generic (#52370)

---
 .../chrono/manager_confirm_source_delete.html |  4 +-
 .../chrono/manager_import_exceptions.html     |  5 +-
 .../chrono/manager_replace_exceptions.html    |  2 +-
 .../manager_time_period_exception_form.html   |  2 +-
 chrono/manager/views.py                       | 50 +++----------------
 5 files changed, 14 insertions(+), 49 deletions(-)

diff --git a/chrono/manager/templates/chrono/manager_confirm_source_delete.html b/chrono/manager/templates/chrono/manager_confirm_source_delete.html
index 8eaf1b63..4ef0fc04 100644
--- a/chrono/manager/templates/chrono/manager_confirm_source_delete.html
+++ b/chrono/manager/templates/chrono/manager_confirm_source_delete.html
@@ -1,4 +1,4 @@
-{% extends "chrono/manager_home.html" %}
+{% extends base_template %}
 {% load i18n %}
 
 {% block appbar %}
@@ -13,7 +13,7 @@
   </p>
   <div class="buttons">
     <button class="delete-button">{% trans 'Delete' %}</button>
-    <a class="cancel" href="{% url 'chrono-manager-agenda-settings' object.desk.agenda_id %}">{% trans 'Cancel' %}</a>
+    <a class="cancel" href="{{ view.get_success_url }}">{% trans 'Cancel' %}</a>
   </div>
 </form>
 {% endblock %}
diff --git a/chrono/manager/templates/chrono/manager_import_exceptions.html b/chrono/manager/templates/chrono/manager_import_exceptions.html
index 6cfe2b15..e5004527 100644
--- a/chrono/manager/templates/chrono/manager_import_exceptions.html
+++ b/chrono/manager/templates/chrono/manager_import_exceptions.html
@@ -1,4 +1,4 @@
-{% extends "chrono/manager_agenda_view.html" %}
+{% extends base_template %}
 {% load i18n %}
 
 {% block extrascripts %}
@@ -8,7 +8,6 @@
 
 {% block breadcrumb %}
 {{ block.super }}
-<a href="{% url 'chrono-manager-agenda-settings' agenda.pk %}">{% trans 'Settings' %}</a>
 <a href="">{% trans "Manage exception sources" %}</a>
 {% endblock %}
 
@@ -52,7 +51,7 @@
   </p>
   <div class="buttons">
     <button>{% trans "Import" %}</button>
-    <a class="cancel" href="{% url 'chrono-manager-agenda-settings' pk=agenda.id %}">{% trans 'Cancel' %}</a>
+    <a class="cancel" href="{{ view.get_success_url }}">{% trans 'Cancel' %}</a>
   </div>
 </form>
 {% endblock %}
diff --git a/chrono/manager/templates/chrono/manager_replace_exceptions.html b/chrono/manager/templates/chrono/manager_replace_exceptions.html
index 6f9f8309..906591f7 100644
--- a/chrono/manager/templates/chrono/manager_replace_exceptions.html
+++ b/chrono/manager/templates/chrono/manager_replace_exceptions.html
@@ -14,7 +14,7 @@
   </p>
   <div class="buttons">
     <button>{% trans "Replace" %}</button>
-    <a class="cancel" href="{% url 'chrono-manager-agenda-settings' pk=agenda.id %}">{% trans 'Cancel' %}</a>
+    <a class="cancel" href="{{ view.get_success_url }">{% trans 'Cancel' %}</a>
   </div>
 </form>
 {% endblock %}
diff --git a/chrono/manager/templates/chrono/manager_time_period_exception_form.html b/chrono/manager/templates/chrono/manager_time_period_exception_form.html
index 1e846920..4fb663e6 100644
--- a/chrono/manager/templates/chrono/manager_time_period_exception_form.html
+++ b/chrono/manager/templates/chrono/manager_time_period_exception_form.html
@@ -40,7 +40,7 @@
   {% endfor %}
   <div class="buttons">
     <button class="submit-button">{% trans "Save" %}</button>
-    <a class="cancel" href="{{ cancel_url }}">{% trans 'Cancel' %}</a>
+    <a class="cancel" href="{{ view.get_success_url }}">{% trans 'Cancel' %}</a>
   </div>
 
   <script>
diff --git a/chrono/manager/views.py b/chrono/manager/views.py
index 2176672f..46890d06 100644
--- a/chrono/manager/views.py
+++ b/chrono/manager/views.py
@@ -1584,25 +1584,6 @@ class ManagedDeskMixin:
         return reverse('chrono-manager-agenda-settings', kwargs={'pk': self.desk.agenda.id})
 
 
-class ManagedDeskSubobjectMixin:
-    desk = None
-
-    def dispatch(self, request, *args, **kwargs):
-        self.desk = self.get_object().desk
-        if not self.desk.agenda.can_be_managed(request.user):
-            raise PermissionDenied()
-        return super().dispatch(request, *args, **kwargs)
-
-    def get_context_data(self, **kwargs):
-        context = super().get_context_data(**kwargs)
-        context['desk'] = self.object.desk
-        context['agenda'] = self.object.desk.agenda
-        return context
-
-    def get_success_url(self):
-        return reverse('chrono-manager-agenda-settings', kwargs={'pk': self.desk.agenda.id})
-
-
 class ManagedTimePeriodMixin:
     agenda = None
 
@@ -1647,8 +1628,10 @@ class ManagedTimePeriodExceptionMixin:
         if self.desk:
             context['desk'] = self.object.desk
             context['agenda'] = self.object.desk.agenda
+            context['base_template'] = 'chrono/manager_agenda_settings.html'
         else:
             context['unavailability_calendar'] = self.unavailability_calendar
+            context['base_template'] = 'chrono/manager_unavailability_calendar_settings.html'
         return context
 
     def get_success_url(self):
@@ -2707,21 +2690,6 @@ class TimePeriodExceptionEditView(ManagedTimePeriodExceptionMixin, UpdateView):
     model = TimePeriodException
     form_class = TimePeriodExceptionForm
 
-    def get_context_data(self, **kwargs):
-        context = super().get_context_data(**kwargs)
-        if self.desk:
-            context['base_template'] = 'chrono/manager_agenda_settings.html'
-            context['cancel_url'] = reverse(
-                'chrono-manager-agenda-settings', kwargs={'pk': self.desk.agenda.pk}
-            )
-        elif self.unavailability_calendar:
-            context['base_template'] = 'chrono/manager_unavailability_calendar_settings.html'
-            context['cancel_url'] = reverse(
-                'chrono-manager-unavailability-calendar-settings',
-                kwargs={'pk': self.unavailability_calendar.pk},
-            )
-        return context
-
     def form_valid(self, form):
         result = super().form_valid(form)
         messages.info(self.request, _('Exception updated.'))
@@ -2829,6 +2797,7 @@ class DeskImportTimePeriodExceptionsView(ManagedAgendaSubobjectMixin, UpdateView
                 )
             )
         )
+        context['base_template'] = 'chrono/manager_agenda_settings.html'
         return context
 
     def import_file(self, desk, form):
@@ -2871,13 +2840,10 @@ class DeskImportTimePeriodExceptionsView(ManagedAgendaSubobjectMixin, UpdateView
 desk_import_time_period_exceptions = DeskImportTimePeriodExceptionsView.as_view()
 
 
-class TimePeriodExceptionSourceDeleteView(ManagedDeskSubobjectMixin, DeleteView):
+class TimePeriodExceptionSourceDeleteView(ManagedTimePeriodExceptionMixin, DeleteView):
     template_name = 'chrono/manager_confirm_source_delete.html'
     model = TimePeriodExceptionSource
 
-    def get_success_url(self):
-        return reverse('chrono-manager-agenda-settings', kwargs={'pk': self.desk.agenda_id})
-
     def delete(self, request, *args, **kwargs):
         source = self.get_object()
         response = super().delete(request, *args, **kwargs)
@@ -2900,7 +2866,7 @@ class TimePeriodExceptionSourceDeleteView(ManagedDeskSubobjectMixin, DeleteView)
 time_period_exception_source_delete = TimePeriodExceptionSourceDeleteView.as_view()
 
 
-class TimePeriodExceptionSourceReplaceView(ManagedDeskSubobjectMixin, UpdateView):
+class TimePeriodExceptionSourceReplaceView(ManagedTimePeriodExceptionMixin, UpdateView):
     model = TimePeriodExceptionSource
     form_class = TimePeriodExceptionSourceReplaceForm
     template_name = 'chrono/manager_replace_exceptions.html'
@@ -2935,7 +2901,7 @@ class TimePeriodExceptionSourceReplaceView(ManagedDeskSubobjectMixin, UpdateView
 time_period_exception_source_replace = TimePeriodExceptionSourceReplaceView.as_view()
 
 
-class TimePeriodExceptionSourceRefreshView(ManagedDeskSubobjectMixin, DetailView):
+class TimePeriodExceptionSourceRefreshView(ManagedTimePeriodExceptionMixin, DetailView):
     model = TimePeriodExceptionSource
 
     def get_queryset(self):
@@ -2960,7 +2926,7 @@ class TimePeriodExceptionSourceRefreshView(ManagedDeskSubobjectMixin, DetailView
 
         messages.info(self.request, _('Exceptions will be synchronized in a few minutes.'))
         # redirect to settings
-        return HttpResponseRedirect(reverse('chrono-manager-agenda-settings', kwargs={'pk': desk.agenda_id}))
+        return HttpResponseRedirect(self.get_success_url())
 
 
 time_period_exception_source_refresh = TimePeriodExceptionSourceRefreshView.as_view()
@@ -3166,7 +3132,7 @@ class EventCreateRecurrenceView(ViewableAgendaMixin, RedirectView):
 event_create_recurrence = EventCreateRecurrenceView.as_view()
 
 
-class TimePeriodExceptionSourceToggleView(ManagedDeskSubobjectMixin, DetailView):
+class TimePeriodExceptionSourceToggleView(ManagedTimePeriodExceptionMixin, DetailView):
     model = TimePeriodExceptionSource
 
     def get_object(self, queryset=None):
-- 
2.30.2