From f0ccab05b3fa19ad6ca0603eacc20308e05cde58 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= <fpeters@entrouvert.com>
Date: Tue, 19 May 2015 17:17:02 +0200
Subject: [PATCH 2/2] forms: add a "preview" mode for disabled forms (#22)

---
 tests/test_form_pages.py | 24 ++++++++++++++++++++++++
 wcs/admin/forms.py       |  5 ++++-
 wcs/formdef.py           |  4 +++-
 wcs/forms/root.py        | 12 ++++++++----
 wcs/root.py              |  4 +++-
 5 files changed, 42 insertions(+), 7 deletions(-)

diff --git a/tests/test_form_pages.py b/tests/test_form_pages.py
index ef0be89..956947e 100644
--- a/tests/test_form_pages.py
+++ b/tests/test_form_pages.py
@@ -625,3 +625,27 @@ def test_form_count_dispatching(pub):
 
     assert len(formdef.data_class().select(clause=lambda x: x.status == 'wf-st2')) == 1
     assert len(formdef.data_class().select(clause=lambda x: x.status == 'wf-st1')) == 1
+
+def test_preview_form(pub):
+    user = create_user(pub)
+
+    formdef = create_formdef()
+    formdef.fields = []
+    formdef.disabled = True
+    formdef.store()
+
+    # check the preview page is not accessible to regular users
+    get_app(pub).get('/preview/test/', status=403)
+
+    # check it's accessible to admins
+    user.is_admin = True
+    user.store()
+    page = login(get_app(pub), username='foo', password='foo').get('/preview/test/')
+
+    # check no formdata gets stored
+    next_page = page.forms[0].submit('submit')
+    assert 'Check values then click submit.' in next_page.body
+    next_page = next_page.forms[0].submit('submit')
+    assert next_page.status_int == 302
+    assert next_page.location == 'http://example.net/preview/test/'
+    assert formdef.data_class().count() == 0
diff --git a/wcs/admin/forms.py b/wcs/admin/forms.py
index 77fee50..3eecbb5 100644
--- a/wcs/admin/forms.py
+++ b/wcs/admin/forms.py
@@ -381,7 +381,10 @@ class FormDefPage(Directory):
         r += htmltext('</ul>')
 
         r += htmltext('<ul>')
-        if not self.formdef.is_disabled():
+        if self.formdef.is_disabled():
+            r += htmltext('<li><a href="%s">%s</a></li>') % (
+                    self.formdef.get_url(preview=True), _('Preview Online'))
+        else:
             r += htmltext('<li><a href="%s">%s</a></li>') % (
                     self.formdef.get_url(), _('Display Online'))
         if qrcode is not None:
diff --git a/wcs/formdef.py b/wcs/formdef.py
index ce23d88..44d030d 100644
--- a/wcs/formdef.py
+++ b/wcs/formdef.py
@@ -329,9 +329,11 @@ class FormDef(StorableObject):
         return cls.get_on_index(url_name, 'url_name', ignore_migration=ignore_migration)
     get_by_urlname = classmethod(get_by_urlname)
 
-    def get_url(self, backoffice = False):
+    def get_url(self, backoffice=False, preview=False):
         if backoffice:
             base_url = get_publisher().get_backoffice_url() + '/management'
+        elif preview:
+            base_url = get_publisher().get_frontoffice_url() + '/preview'
         else:
             base_url = get_publisher().get_frontoffice_url()
         return '%s/%s/' % (base_url, self.url_name)
diff --git a/wcs/forms/root.py b/wcs/forms/root.py
index 3b9ddd8..b0d4531 100644
--- a/wcs/forms/root.py
+++ b/wcs/forms/root.py
@@ -437,15 +437,19 @@ class FormPage(Directory):
         formdata.status = str('')
         get_publisher().substitutions.feed(formdata)
 
-    def _q_index(self, log_detail = None, editing = None):
-        self.check_role()
+    def check_disabled(self):
         if self.formdef.is_disabled():
             if self.formdef.disabled_redirection:
-                url = misc.get_variadic_url(self.formdef.disabled_redirection,
+                return misc.get_variadic_url(self.formdef.disabled_redirection,
                         get_publisher().substitutions.get_context_variables())
-                return redirect(url)
             else:
                 raise errors.AccessForbiddenError()
+        return False
+
+    def _q_index(self, log_detail = None, editing = None):
+        self.check_role()
+        if self.check_disabled():
+            return redirect(self.check_disabled())
 
         session = get_session()
 
diff --git a/wcs/root.py b/wcs/root.py
index 10b880b..778e9bd 100644
--- a/wcs/root.py
+++ b/wcs/root.py
@@ -51,6 +51,7 @@ from anonylink import AnonymityLink
 from roles import Role
 from wcs.api import get_user_from_api_query_string, ApiDirectory
 from myspace import MyspaceDirectory
+from forms.preview import PreviewDirectory
 
 
 class CompatibilityDirectory(Directory):
@@ -194,7 +195,7 @@ class RootDirectory(Directory):
     _q_exports = ['admin', 'backoffice', 'forms', 'login', 'logout', 'token', 'saml',
             'ident', 'register', 'afterjobs', 'themes', 'myspace', 'user', 'roles',
             'pages', ('tmp-upload', 'tmp_upload'), 'api', '__version__',
-            'tryauth', 'auth']
+            'tryauth', 'auth', 'preview']
 
     api = ApiDirectory()
     themes = template.ThemesDirectory()
@@ -380,3 +381,4 @@ class RootDirectory(Directory):
     register = RegisterDirectory()
     ident = IdentDirectory()
     afterjobs = AfterJobStatusDirectory()
+    preview = PreviewDirectory()
-- 
2.1.4