From 75390e1dc7b2e0308b9fe2ae42467fd9ee8afbe6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Corentin=20S=C3=A9chet?= <csechet@entrouvert.com>
Date: Wed, 10 Aug 2022 17:38:02 +0200
Subject: [PATCH] general: add BEM classes on menus (#68106)

---
 combo/public/templates/combo/menu.html | 12 ++++++++----
 combo/public/templatetags/combo.py     |  5 ++++-
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/combo/public/templates/combo/menu.html b/combo/public/templates/combo/menu.html
index a25fc3dd..5c234902 100644
--- a/combo/public/templates/combo/menu.html
+++ b/combo/public/templates/combo/menu.html
@@ -1,13 +1,17 @@
 {% load i18n %}
 {% if menuitems %}
-<ul>
+<ul class="{{ is_submenu|yesno:"submenu,menu" }}">
 {% spaceless %}
 {% for menuitem in menuitems %}
-<li data-menu-page-id="{{ menuitem.page.id }}" class="menu-{{ menuitem.page.slug }} {% if menuitem.selected %}selected{% endif %}"><a
+<li data-menu-page-id="{{ menuitem.page.id }}" class="{{ is_submenu|yesno:"submenu,menu" }}-item menu-{{ menuitem.page.slug }} {% if menuitem.selected %}selected{% endif %}">
+  <a
     {% if menuitem.selected %}title="{{ menuitem.page.title }} - {% trans "active page" %}"{% endif %}
-    href="{% page_absolute_url menuitem.page %}"><span>{{ menuitem.page.title }}</span></a>
+    href="{% page_absolute_url menuitem.page %}"
+    class="{{ is_submenu|yesno:"submenu,menu" }}-item--link">
+      <span class="{{ is_submenu|yesno:"submenu,menu" }}-item--label">{{ menuitem.page.title }}</span>
+  </a>
   {% if depth > 1 %}
-    {% show_menu current_page=menuitem.page level=-1 depth=depth reduce_depth=True ignore_visibility=ignore_visibility %}
+    {% show_menu current_page=menuitem.page level=-1 depth=depth reduce_depth=True ignore_visibility=ignore_visibility is_submenu=True %}
   {% endif %}
 </li>
 {% endfor %}
diff --git a/combo/public/templatetags/combo.py b/combo/public/templatetags/combo.py
index 947261ba..95bee45c 100644
--- a/combo/public/templatetags/combo.py
+++ b/combo/public/templatetags/combo.py
@@ -213,13 +213,16 @@ class ExtraPlaceholderNode(template.Node):
 
 
 @register.inclusion_tag('combo/menu.html', takes_context=True)
-def show_menu(context, level=0, current_page=None, depth=1, ignore_visibility=True, reduce_depth=False):
+def show_menu(
+    context, level=0, current_page=None, depth=1, ignore_visibility=True, reduce_depth=False, is_submenu=False
+):
     if reduce_depth:
         depth -= 1
     new_context = {
         'page': context['page'],
         'render_skeleton': context.get('render_skeleton'),
         'request': context['request'],
+        'is_submenu': is_submenu,
     }
     return get_menu_context(
         new_context, level=level, current_page=current_page, depth=depth, ignore_visibility=ignore_visibility
-- 
2.35.1