From 9e03615300799f5b12a6ae402e03f014927c906f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Corentin=20S=C3=A9chet?= <csechet@entrouvert.com>
Date: Wed, 21 Sep 2022 14:02:57 +0200
Subject: [PATCH] misc: avoid javascript in MiniRichTextWidget template
 (#59585)

---
 tests/test_widgets.py                                     | 7 +++++++
 .../templates/qommon/forms/widgets/mini-rich-text.html    | 8 +++-----
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/tests/test_widgets.py b/tests/test_widgets.py
index f5e08d030..259a3db89 100644
--- a/tests/test_widgets.py
+++ b/tests/test_widgets.py
@@ -17,6 +17,7 @@ from wcs.qommon.form import (
     FileWithPreviewWidget,
     Form,
     MapWidget,
+    MiniRichTextWidget,
     OptGroup,
     PasswordEntryWidget,
     SingleSelectHintWidget,
@@ -515,6 +516,12 @@ def test_wysiwygwidget_img():
     assert widget.parse() == '<p><img src="/test/"></p>'
 
 
+def test_mini_rich_text_widget():
+    widget = MiniRichTextWidget('test')
+    form = MockHtmlForm(widget)
+    assert 'data-godo="basic"' in form.as_html
+
+
 def test_select_hint_widget():
     widget = SingleSelectHintWidget(
         'test', options=[('apple', 'Apple', 'apple'), ('pear', 'Pear', 'pear'), ('peach', 'Peach', 'peach')]
diff --git a/wcs/qommon/templates/qommon/forms/widgets/mini-rich-text.html b/wcs/qommon/templates/qommon/forms/widgets/mini-rich-text.html
index 594af2630..c92b8570a 100644
--- a/wcs/qommon/templates/qommon/forms/widgets/mini-rich-text.html
+++ b/wcs/qommon/templates/qommon/forms/widgets/mini-rich-text.html
@@ -2,9 +2,7 @@
 {% block widget-control %}
 <textarea style="width: 100%" id="form_{{widget.get_name_for_id}}" name="{{widget.name}}"
     {% for attr in widget.attrs.items %}{{attr.0}}="{{attr.1}}" {% endfor %}
-    >{{widget.value|default:""}}</textarea>
-<script type="module">
-import Godo from "/static/xstatic/js/godo.js?{{version_hash}}";
-new Godo(document.getElementById('form_{{widget.get_name_for_id}}'), {schema: 'basic'});
-</script>
+    data-godo="basic">{{widget.value|default:""}}
+</textarea>
+<script type="module" src="/static/xstatic/js/godo.js?{{version_hash}}"></script>
 {% endblock %}
-- 
2.35.1