From 05a1c60efe1c19d16cbe8dd22c745a9e81863349 Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Wed, 19 Oct 2022 11:43:59 +0200 Subject: [PATCH] torebase: ecazenave remark on logout() (#69720) --- src/authentic2/views.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/authentic2/views.py b/src/authentic2/views.py index cfd82b80..69e58edc 100644 --- a/src/authentic2/views.py +++ b/src/authentic2/views.py @@ -628,18 +628,17 @@ def logout(request, next_url=None, do_local=True, check_referer=True): # Get redirection targets for full logout with redirections # (needed before local logout) targets = redirect_logout_list(request) + # Last redirection will be the current next_url targets.append(next_url) # Local logout request.journal.record('user.logout') auth_logout(request) - # Last redirection will be the current next_url - # Put redirection targets in session (after local logout) - request.session['logout_redirections'] = targets - targets = request.session.pop('logout_redirections', None) if targets: # Full logout with redirections next_url = targets.pop(0) - request.session['logout_redirections'] = targets + if targets: + # Put redirection targets in session + request.session['logout_redirections'] = targets response = shortcuts.redirect(next_url) response.set_cookie('a2_just_logged_out', 1, max_age=60, samesite='Lax') return response -- 2.37.2