From 33cd3c4084832ec1afc8b8af4a97410718bf53eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= Date: Wed, 19 Aug 2015 09:29:14 +0200 Subject: [PATCH] xml: handle failure of xmlSecBase64Decode() (#8070) --- lasso/xml/tools.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lasso/xml/tools.c b/lasso/xml/tools.c index 1b94ac3..36612a3 100644 --- a/lasso/xml/tools.c +++ b/lasso/xml/tools.c @@ -1325,6 +1325,11 @@ lasso_node_init_from_deflated_query_part(LassoNode *node, char *deflate_string) zre = xmlMalloc(len*4); len = xmlSecBase64Decode(b64_zre, zre, len*4); xmlFree(b64_zre); + if (len == -1) { + message(G_LOG_LEVEL_CRITICAL, "Failed to base64-decode query"); + xmlFree(zre); + return FALSE; + } zstr.zalloc = NULL; zstr.zfree = NULL; -- 2.5.0